From: Rolf Eike Beer <eike@bilbo.math.uni-mannheim.de>
To: Jan Dittmer <jdittmer@ppp0.net>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sr module_param conversion
Date: Sun, 21 Nov 2004 12:13:38 +0100 [thread overview]
Message-ID: <200411211213.38129@bilbo.math.uni-mannheim.de> (raw)
In-Reply-To: <41969B65.9000807@ppp0.net>
Jan Dittmer wrote:
> module_param conversion for SCSI cdrom driver
>
> Signed-off-by: Jan Dittmer <jdittmer@ppp0.net>
> diff -Nru a/drivers/scsi/sr_ioctl.c b/drivers/scsi/sr_ioctl.c
> --- a/drivers/scsi/sr_ioctl.c 2004-11-14 00:36:56 +01:00
> +++ b/drivers/scsi/sr_ioctl.c 2004-11-14 00:36:56 +01:00
> @@ -29,6 +29,9 @@
> * It is off by default and can be turned on with this module parameter */
> static int xa_test = 0;
>
> +module_param(xa_test, int, S_IRUGO | S_IWUSR);
> +
> +
I think it should be "bool" instead of "int". And one newline should be
enough for everyone.
You should CC linux-scsi@vger.kernel.org and James Bottomley
<James.Bottomley@steeleye.com> to get this applied.
Eike
prev parent reply other threads:[~2004-11-21 11:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-13 23:40 [PATCH] sr module_param conversion Jan Dittmer
2004-11-21 11:13 ` Rolf Eike Beer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200411211213.38129@bilbo.math.uni-mannheim.de \
--to=eike@bilbo.math.uni-mannheim.de \
--cc=jdittmer@ppp0.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.