Re: [2.6 patch] small input cleanup

[Adrian Bunk <bunk@stusta.de>]

On Sun, Nov 07, 2004 at 06:47:57PM +0100, Vojtech Pavlik wrote:
> On Sun, Nov 07, 2004 at 06:29:29PM +0100, Adrian Bunk wrote:
> > On Sat, Nov 06, 2004 at 10:49:54PM -0500, Dmitry Torokhov wrote:
> > 
> > > Hi,
> > 
> > Hi Dmitry,
> > 
> > > On Saturday 06 November 2004 10:12 pm, Adrian Bunk wrote:
> > > > The patch below does the following cleanups under drivers/input/ :
> > > > - make some needlessly global code static
> > > > - remove the completely unused EXPORT_SYMBOL'ed function gameport_rescan
> > > 
> > > It will be used (but in some transformed) once I finish gameport sysfs
> > > support, but it probably need not be exported.
> > >  
> > > > - make the EXPORT_SYMBOL'ed function ps2_sendbyte static since it isn't
> > > >   used outside the file where it's defined
> > > 
> > > libps2 is a library for communicating with standard PS/2 device and while
> > > the function is not currently used it is part of the interface. I would
> > > like to leave the function as is.
> > 
> > my personal opinions:
> > - if gameport_rescan will not be needed in it's current form, there's
> >   no need for it (you can always add the "real" function when it's 
> >   required
> 
> Well, it works in its current form, and drivers should call it when
> their reinit logic fails to reinitialize the device. They don't, which
> is a bug, and should be fixed. I don't think removing gameport_rescan()
> will help fixing them.

Fine with me.

> > - could ps2_sendbyte be #ifdef 0'ed until it's required?
> >   this way, it wouldn't make the kernel bigger today
>  
> It is used, just not outside libps2. Does the EXPORT_SYMBOL() make the
> kernel so much bigger?

It doesn't make a big difference, but if an EXPORT_SYMBOL isn't required 
(and won't be required in the near future), where's the point keeping 
it?

The situation is clearly different if in-kernel users from other files 
will be added in the near future.

> Vojtech Pavlik

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed