From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Christoph Hellwig <hch@infradead.org>,
Adrian Bunk <bunk@stusta.de>, Antonino Daplas <adaplas@pol.net>,
linux-kernel@vger.kernel.org,
linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [2.6 patch] cyber2000fb.c: misc cleanups
Date: Mon, 22 Nov 2004 00:04:13 +0000 [thread overview]
Message-ID: <20041122000413.A27572@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20041121205613.GA12634@infradead.org>; from hch@infradead.org on Sun, Nov 21, 2004 at 08:56:13PM +0000
On Sun, Nov 21, 2004 at 08:56:13PM +0000, Christoph Hellwig wrote:
> On Sun, Nov 21, 2004 at 08:47:52PM +0000, Russell King wrote:
> > On Sun, Nov 21, 2004 at 04:36:14PM +0100, Adrian Bunk wrote:
> > > The patch below ncludes the following cleanups for
> > > drivers/video/cyber2000fb.c:
> > > - remove five EXPORT_SYMBOL'ed but completely unused functions
> > > - make some needlessly global code static
> >
> > These are used by the video capture code which isn't merged, but is
> > used by people. Rejected.
>
> If people use the code it should get merged or Adrian has all reasons to
> remove or #if 0 the code.
Sigh, if that's what you want to do and place extra burden on me,
that's fine. Don't expect me to co-operate with you next time you
want me to do something though, no matter how important you feel it
is. Works both ways.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
next prev parent reply other threads:[~2004-11-22 0:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-21 15:36 [2.6 patch] cyber2000fb.c: misc cleanups Adrian Bunk
2004-11-21 20:47 ` Russell King
2004-11-21 20:56 ` Christoph Hellwig
2004-11-22 0:04 ` Russell King [this message]
2004-11-22 0:10 ` Adrian Bunk
2004-11-22 0:21 ` Russell King
2004-11-22 1:05 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041122000413.A27572@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=adaplas@pol.net \
--cc=bunk@stusta.de \
--cc=hch@infradead.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.