From: Jens Axboe <axboe@suse.de>
To: Tobias DiPasquale <codeslinger@gmail.com>
Cc: linux-kernel@vger.kernel.org, akpm@digeo.com
Subject: Re: [PATCH] add list_del_head function
Date: Mon, 22 Nov 2004 10:20:59 +0100 [thread overview]
Message-ID: <20041122092059.GA16487@suse.de> (raw)
In-Reply-To: <876ef97a04112007562d6797e@mail.gmail.com>
On Sat, Nov 20 2004, Tobias DiPasquale wrote:
> Hi all,
>
> I was working with some queues the other day and I noticed that there
> was a list_add_tail() function in list.h, but no list_del_head()
> function. This struck me as a little odd, so I went ahead and
> implemented one in order to complete full queue functionality. The
> patch below was generated against pristine 2.6.9 kernel.org kernel
> sources and is attached to this email.
Generally patches like this have little merrit unless accompanied by
another patch converting several obvious pieces of kernel code to use
it.
Also I find the interface awkward and different from the other list
functions.
entry = list_del_head(list);
would have been much nicer.
--
Jens Axboe
next prev parent reply other threads:[~2004-11-22 9:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-20 15:56 [PATCH] add list_del_head function Tobias DiPasquale
2004-11-22 9:20 ` Jens Axboe [this message]
2004-11-22 16:18 ` Tobias DiPasquale
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041122092059.GA16487@suse.de \
--to=axboe@suse.de \
--cc=akpm@digeo.com \
--cc=codeslinger@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.