From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>, Michael Hunold <hunold@linuxtv.org>
Cc: linux-kernel@vger.kernel.org, linux-dvb-maintainer@linuxtv.org
Subject: [patch] 2.6.10-rc2-mm3: DVB: philips_tdm1316l_config multiple definition
Date: Mon, 22 Nov 2004 16:51:23 +0100 [thread overview]
Message-ID: <20041122155123.GE19419@stusta.de> (raw)
In-Reply-To: <20041121223929.40e038b2.akpm@osdl.org>
On Sun, Nov 21, 2004 at 10:39:29PM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.10-rc2-mm2:
>...
> +dvb-follow-frontend-changes-in-drivers.patch
>...
> +dvb-follow-changes-in-dvb-ttpci-and-budget-drivers.patch
>
> Big DVB update
>...
<-- snip -->
...
LD drivers/media/dvb/built-in.o
drivers/media/dvb/ttusb-budget/built-in.o(.data+0x3364): multiple
definition of `philips_tdm1316l_config'
drivers/media/dvb/ttpci/built-in.o(.data+0x8c8): first defined here
make[3]: *** [drivers/media/dvb/built-in.o] Error 1
<-- snip -->
Since none of them has a good reason for being global, the patch below
makes both static.
diffstat output:
drivers/media/dvb/ttpci/budget-ci.c | 2 +-
drivers/media/dvb/ttusb-budget/dvb-ttusb-budget.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-rc2-mm3-full/drivers/media/dvb/ttpci/budget-ci.c.old 2004-11-22 14:48:33.000000000 +0100
+++ linux-2.6.10-rc2-mm3-full/drivers/media/dvb/ttpci/budget-ci.c 2004-11-22 14:48:45.000000000 +0100
@@ -840,7 +840,7 @@
return request_firmware(fw, name, &budget_ci->budget.dev->pci->dev);
}
-struct tda1004x_config philips_tdm1316l_config = {
+static struct tda1004x_config philips_tdm1316l_config = {
.demod_address = 0x8,
.invert = 0,
--- linux-2.6.10-rc2-mm3-full/drivers/media/dvb/ttusb-budget/dvb-ttusb-budget.c.old 2004-11-22 14:48:59.000000000 +0100
+++ linux-2.6.10-rc2-mm3-full/drivers/media/dvb/ttusb-budget/dvb-ttusb-budget.c 2004-11-22 14:49:08.000000000 +0100
@@ -1190,7 +1190,7 @@
return request_firmware(fw, name, &ttusb->dev->dev);
}
-struct tda1004x_config philips_tdm1316l_config = {
+static struct tda1004x_config philips_tdm1316l_config = {
.demod_address = 0x8,
.invert = 1,
next prev parent reply other threads:[~2004-11-22 16:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-22 6:39 2.6.10-rc2-mm3 Andrew Morton
2004-11-22 10:26 ` 2.6.10-rc2-mm3 Paul Mackerras
2004-11-22 13:45 ` 2.6.10-rc2-mm3 Adrian Bunk
2004-11-22 15:51 ` Adrian Bunk [this message]
2004-11-22 16:09 ` [linux-dvb-maintainer] [patch] 2.6.10-rc2-mm3: DVB: philips_tdm1316l_config multiple definition Johannes Stezenbach
2004-11-22 17:01 ` Michael Hunold
2004-11-22 22:08 ` dvb-ttpci not smp safe [was: [linux-dvb-maintainer] [patch] 2.6.10-rc2-mm3: DVB: philips_tdm1316l_config multiple definition] syrius.ml
2004-11-22 19:15 ` 2.6.10-rc2-mm3 Chris Ross
2004-11-22 22:44 ` 2.6.10-rc2-mm3 - oops on boot Eyal Lebedinsky
2004-11-22 23:10 ` Andrew Morton
2004-11-23 0:17 ` Eyal Lebedinsky
2004-11-23 11:41 ` Jan Kara
2004-11-23 12:58 ` Chris Ross
2004-11-23 19:13 ` Chris Ross
2004-11-22 23:56 ` 2.6.10-rc2-mm3 Fabio Coatti
2004-11-23 0:21 ` 2.6.10-rc2-mm3 (oops on AMD64) Rafael J. Wysocki
2004-11-24 16:19 ` 2.6.10-rc2-mm3 William Lee Irwin III
2004-11-24 18:53 ` 2.6.10-rc2-mm3 Tom Rini
2004-11-25 2:31 ` 2.6.10-rc2-mm3 J.A. Magallon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041122155123.GE19419@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=hunold@linuxtv.org \
--cc=linux-dvb-maintainer@linuxtv.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.