All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Roland Dreier <roland@topspin.com>
Cc: linux-kernel@vger.kernel.org, openib-general@openib.org
Subject: Re: [PATCH][RFC/v1][4/12] Add InfiniBand SA (Subnet Administration) query support
Date: Mon, 22 Nov 2004 22:41:20 -0800	[thread overview]
Message-ID: <20041123064120.GB22493@kroah.com> (raw)
In-Reply-To: <527jodbgqo.fsf@topspin.com>

On Mon, Nov 22, 2004 at 03:34:23PM -0800, Roland Dreier wrote:
>     Greg> No email address of who to bug with issues?
> 
> There's a patch to MAINTAINERS...

Yeah, but a name in each file is much nicer.

>     Greg> What is "RESERVED"?  I must be missing a previous patch
>     Greg> somewhere, I currently don't see all of the series yet.
> 
> It's in part 1/12: http://article.gmane.org/gmane.linux.kernel/257531
> unfortunately some people marked it as spam and it didn't get
> everywhere.

Thanks for pointing this out. 

One comment, the file drivers/infiniband/core/cache.c has a license that
is illegal due to the contents of the file.  Please change the license
of the file to GPL only.

Oh, and how about kernel-doc comments for all functions that are
EXPORT_SYMBOL() marked?  And for your core big structures?

thanks,

greg k-h

  reply	other threads:[~2004-11-23  6:42 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20041122713.SDrx8l5Z4XR5FsjB@topspin.com>
2004-11-22 15:13 ` [PATCH][RFC/v1][4/12] Add InfiniBand SA (Subnet Administration) query support Roland Dreier
2004-11-22 19:33   ` Sam Ravnborg
2004-11-22 21:28     ` Roland Dreier
2004-11-22 22:25   ` Greg KH
2004-11-22 22:40     ` [openib-general] Re: [PATCH][RFC/v1][4/12] Add InfiniBand SA(Subnet " Fab Tillier
2004-11-22 23:34     ` [PATCH][RFC/v1][4/12] Add InfiniBand SA (Subnet " Roland Dreier
2004-11-23  6:41       ` Greg KH [this message]
2004-11-23  6:47         ` Roland Dreier
2004-11-23  7:29           ` Greg KH
2004-11-23 17:52             ` [openib-general] " Johannes Erdfelt
2004-11-23 18:38               ` Greg KH
2004-11-23 18:56                 ` Roland Dreier
2004-11-23 19:01                   ` Greg KH
2004-11-23 19:13                 ` Johannes Erdfelt
2004-11-23 19:30                 ` linux-os
2004-11-23 19:42                   ` Greg KH
2004-11-24 19:23                 ` Roland Dreier
2004-11-24 19:29                   ` Greg KH
2004-11-23 15:27         ` Randy.Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041123064120.GB22493@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openib-general@openib.org \
    --cc=roland@topspin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.