All of lore.kernel.org
 help / color / mirror / Atom feed
diff for duplicates of <20041123165236.GA4936@penguincomputing.com>

diff --git a/a/1.txt b/N1/1.txt
index 9c3789e..fff18df 100644
--- a/a/1.txt
+++ b/N1/1.txt
@@ -5,8 +5,8 @@ constructs.  I have also switched from using MODULE_PARM() to
 module_param_array().  As Jean requested (and as I muttonheadedly ignored)
 on the last submission, the diff now includes the patches to 
 
-../drivers/i2c/chips/Makefile
-../drivers/i2c/chips/Kconfig
+.../drivers/i2c/chips/Makefile
+.../drivers/i2c/chips/Kconfig
 
 Finally (and you've all read this before):
 
@@ -315,11 +315,11 @@ diff -uprN -X dontdiff linux-2.6.10-rc2-vanilla/drivers/i2c/chips/adm1026.c linu
 +
 +/* FAN speed is measured using 22.5kHz clock and counts for 2 pulses
 + *   and we assume a 2 pulse-per-rev fan tach signal
-+ *      22500 kHz * 60 (sec/min) * 2 (pulse) / 2 (pulse/rev) = 1350000
++ *      22500 kHz * 60 (sec/min) * 2 (pulse) / 2 (pulse/rev) == 1350000
 + */
 +#define FAN_TO_REG(val,div)  ((val)<=0 ? 0xff : SENSORS_LIMIT(1350000/((val)*\
 +	(div)),1,254)) 
-+#define FAN_FROM_REG(val,div) ((val)=0?-1:(val)=0xff ? 0 : 1350000/((val)*\
++#define FAN_FROM_REG(val,div) ((val)==0?-1:(val)==0xff ? 0 : 1350000/((val)*\
 +	(div)))
 +#define DIV_FROM_REG(val) (1<<(val))
 +#define DIV_TO_REG(val) ((val)>=8 ? 3 : (val)>=4 ? 2 : (val)>=2 ? 1 : 0)
@@ -490,7 +490,7 @@ diff -uprN -X dontdiff linux-2.6.10-rc2-vanilla/drivers/i2c/chips/adm1026.c linu
 +	/* Inform user of chip config */
 +	dev_dbg(&client->dev, "(%d): ADM1026_REG_CONFIG1 is: 0x%02x\n",
 +		client->id, data->config1);
-+	if ((data->config1 & CFG1_MONITOR) = 0) {
++	if ((data->config1 & CFG1_MONITOR) == 0) {
 +		dev_dbg(&client->dev, "(%d): Monitoring not currently "
 +			"enabled.\n", client->id);
 +	}
@@ -528,7 +528,7 @@ diff -uprN -X dontdiff linux-2.6.10-rc2-vanilla/drivers/i2c/chips/adm1026.c linu
 +	/* Read and pick apart the existing GPIO configuration */
 +	value = 0;
 +	for (i = 0;i <= 15;++i) {
-+		if ((i & 0x03) = 0) {
++		if ((i & 0x03) == 0) {
 +			value = adm1026_read_value(client,
 +					ADM1026_REG_GPIO_CFG_0_3 + i/4);
 +		}
@@ -543,7 +543,7 @@ diff -uprN -X dontdiff linux-2.6.10-rc2-vanilla/drivers/i2c/chips/adm1026.c linu
 +	/* If the user asks us to reprogram the GPIO config, then
 +	 *   do it now.  But only if this is the first ADM1026.
 +	 */
-+	if (client->id = 0
++	if (client->id == 0
 +	    && (gpio_input[0] != -1 || gpio_output[0] != -1
 +		|| gpio_inverted[0] != -1 || gpio_normal[0] != -1
 +		|| gpio_fan[0] != -1)) {
@@ -561,7 +561,7 @@ diff -uprN -X dontdiff linux-2.6.10-rc2-vanilla/drivers/i2c/chips/adm1026.c linu
 +	 *   without first setting a value for pwm1.auto_pwm_min 
 +	 *   will not result in potentially dangerous fan speed decrease.
 +	 */
-+	data->pwm1.auto_pwm_min%5;
++	data->pwm1.auto_pwm_min=255;
 +	/* Start monitoring */
 +	value = adm1026_read_value(client, ADM1026_REG_CONFIG1);
 +	/* Set MONITOR, clear interrupt acknowledge and s/w reset */
@@ -669,7 +669,7 @@ diff -uprN -X dontdiff linux-2.6.10-rc2-vanilla/drivers/i2c/chips/adm1026.c linu
 +	for (i = 15, value = 0;i >= 0;--i) {
 +		value <<= 2;
 +		value |= data->gpio_config[i] & 0x03;
-+		if ((i & 0x03) = 0) {
++		if ((i & 0x03) == 0) {
 +			adm1026_write_value(client,
 +					ADM1026_REG_GPIO_CFG_0_3 + i/4,
 +					value);
@@ -696,17 +696,20 @@ diff -uprN -X dontdiff linux-2.6.10-rc2-vanilla/drivers/i2c/chips/adm1026.c linu
 +		dev_dbg(&client->dev,"(%d): Reading sensor values\n", 
 +			client->id);
 +		for (i = 0;i <= 16;++i) {
-+			data->in[i] +			    adm1026_read_value(client, ADM1026_REG_IN[i]);
++			data->in[i] =
++			    adm1026_read_value(client, ADM1026_REG_IN[i]);
 +		}
 +
 +		for (i = 0;i <= 7;++i) {
-+			data->fan[i] +			    adm1026_read_value(client, ADM1026_REG_FAN(i));
++			data->fan[i] =
++			    adm1026_read_value(client, ADM1026_REG_FAN(i));
 +		}
 +
 +		for (i = 0;i <= 2;++i) {
 +			/* NOTE: temp[] is s8 and we assume 2's complement
 +			 *   "conversion" in the assignment   */
-+			data->temp[i] +			    adm1026_read_value(client, ADM1026_REG_TEMP[i]);
++			data->temp[i] =
++			    adm1026_read_value(client, ADM1026_REG_TEMP[i]);
 +		}
 +
 +		data->pwm1.pwm = adm1026_read_value(client, 
@@ -809,7 +812,7 @@ diff -uprN -X dontdiff linux-2.6.10-rc2-vanilla/drivers/i2c/chips/adm1026.c linu
 +
 +		value = 0;
 +		for (i = 0;i <= 15;++i) {
-+			if ((i & 0x03) = 0) {
++			if ((i & 0x03) == 0) {
 +				value = adm1026_read_value(client,
 +					    ADM1026_REG_GPIO_CFG_0_3 + i/4);
 +			}
@@ -1037,7 +1040,7 @@ diff -uprN -X dontdiff linux-2.6.10-rc2-vanilla/drivers/i2c/chips/adm1026.c linu
 +	int    new_div = data->fan_div[fan];
 +
 +	/* 0 and 0xff are special.  Don't adjust them */
-+	if (data->fan_min[fan] = 0 || data->fan_min[fan] = 0xff) {
++	if (data->fan_min[fan] == 0 || data->fan_min[fan] == 0xff) {
 +		return;
 +	}
 +
@@ -1062,7 +1065,7 @@ diff -uprN -X dontdiff linux-2.6.10-rc2-vanilla/drivers/i2c/chips/adm1026.c linu
 +
 +	val = simple_strtol(buf, NULL, 10);
 +	new_div = DIV_TO_REG(val); 
-+	if (new_div = 0) {
++	if (new_div == 0) {
 +		return -EINVAL;
 +	}
 +	down(&data->update_lock);
@@ -1310,7 +1313,7 @@ diff -uprN -X dontdiff linux-2.6.10-rc2-vanilla/drivers/i2c/chips/adm1026.c linu
 +	int     val;
 +
 +	val = simple_strtol(buf, NULL, 10);
-+	if ((val = 1) || (val=0)) {
++	if ((val == 1) || (val==0)) {
 +		down(&data->update_lock);
 +		data->config1 = (data->config1 & ~CFG1_THERM_HOT) | (val << 4);
 +		adm1026_write_value(client, ADM1026_REG_CONFIG1, 
@@ -1530,7 +1533,7 @@ diff -uprN -X dontdiff linux-2.6.10-rc2-vanilla/drivers/i2c/chips/adm1026.c linu
 +	struct adm1026_data *data = i2c_get_clientdata(client);
 +	int     val;
 +
-+	if (data->pwm1.enable = 1) {
++	if (data->pwm1.enable == 1) {
 +		down(&data->update_lock);
 +		val = simple_strtol(buf, NULL, 10);
 +		data->pwm1.pwm = PWM_TO_REG(val);
@@ -1554,7 +1557,7 @@ diff -uprN -X dontdiff linux-2.6.10-rc2-vanilla/drivers/i2c/chips/adm1026.c linu
 +	down(&data->update_lock);
 +	val = simple_strtol(buf, NULL, 10);
 +	data->pwm1.auto_pwm_min = SENSORS_LIMIT(val,0,255);
-+	if (data->pwm1.enable = 2) { /* apply immediately */
++	if (data->pwm1.enable == 2) { /* apply immediately */
 +		data->pwm1.pwm = PWM_TO_REG((data->pwm1.pwm & 0x0f) |
 +			PWM_MIN_TO_REG(data->pwm1.auto_pwm_min)); 
 +		adm1026_write_value(client, ADM1026_REG_PWM, data->pwm1.pwm);
@@ -1585,15 +1588,15 @@ diff -uprN -X dontdiff linux-2.6.10-rc2-vanilla/drivers/i2c/chips/adm1026.c linu
 +		val = simple_strtol(buf, NULL, 10);
 +		data->pwm1.enable = val;
 +		data->config1 = (data->config1 & ~CFG1_PWM_AFC)
-+				| ((val = 2) ? CFG1_PWM_AFC : 0);
++				| ((val == 2) ? CFG1_PWM_AFC : 0);
 +		adm1026_write_value(client, ADM1026_REG_CONFIG1,
 +			data->config1);
-+		if (val = 2) {  /* apply pwm1_auto_pwm_min to pwm1 */
++		if (val == 2) {  /* apply pwm1_auto_pwm_min to pwm1 */
 +			data->pwm1.pwm = PWM_TO_REG((data->pwm1.pwm & 0x0f) |
 +				PWM_MIN_TO_REG(data->pwm1.auto_pwm_min)); 
 +			adm1026_write_value(client, ADM1026_REG_PWM, 
 +				data->pwm1.pwm);
-+		} else if (!((old_enable = 1) && (val = 1))) {
++		} else if (!((old_enable == 1) && (val == 1))) {
 +			/* set pwm to safe value */
 +			data->pwm1.pwm = 255;
 +			adm1026_write_value(client, ADM1026_REG_PWM, 
@@ -1671,15 +1674,15 @@ diff -uprN -X dontdiff linux-2.6.10-rc2-vanilla/drivers/i2c/chips/adm1026.c linu
 +	if (kind <= 0) {
 +		dev_dbg(&new_client->dev, "Autodetecting device at %d,0x%02x "
 +			"...\n", i2c_adapter_id(adapter), address);
-+		if (company = ADM1026_COMPANY_ANALOG_DEV
-+		    && verstep = ADM1026_VERSTEP_ADM1026) {
++		if (company == ADM1026_COMPANY_ANALOG_DEV
++		    && verstep == ADM1026_VERSTEP_ADM1026) {
 +			kind = adm1026;
-+		} else if (company = ADM1026_COMPANY_ANALOG_DEV
-+			&& (verstep & 0xf0) = ADM1026_VERSTEP_GENERIC) {
++		} else if (company == ADM1026_COMPANY_ANALOG_DEV
++			&& (verstep & 0xf0) == ADM1026_VERSTEP_GENERIC) {
 +			dev_err(&adapter->dev, ": Unrecognized stepping "
 +				"0x%02x. Defaulting to ADM1026.\n", verstep);
 +			kind = adm1026;
-+		} else if ((verstep & 0xf0) = ADM1026_VERSTEP_GENERIC) {
++		} else if ((verstep & 0xf0) == ADM1026_VERSTEP_GENERIC) {
 +			dev_err(&adapter->dev, ": Found version/stepping "
 +				"0x%02x. Assuming generic ADM1026.\n",
 +				verstep);
@@ -1688,7 +1691,7 @@ diff -uprN -X dontdiff linux-2.6.10-rc2-vanilla/drivers/i2c/chips/adm1026.c linu
 +			dev_dbg(&new_client->dev, ": Autodetection "
 +				"failed\n");
 +			/* Not an ADM1026 ... */
-+			if (kind = 0)  { /* User used force=x,y */
++			if (kind == 0)  { /* User used force=x,y */
 +				dev_err(&adapter->dev, "Generic ADM1026 not "
 +					"found at %d,0x%02x.  Try "
 +					"force_adm1026.\n",
diff --git a/a/content_digest b/N1/content_digest
index 24fe35f..dccd385 100644
--- a/a/content_digest
+++ b/N1/content_digest
@@ -2,9 +2,9 @@
  "ref\0NN38qQl1.1099468908.1237810.khali@gcu.info\0"
  "ref\020041103164354.GB20465@penguincomputing.com\0"
  "ref\020041118185612.GA20728@penguincomputing.com\0"
- "From\0jthiessen@penguincomputing.com (Justin Thiessen)\0"
- "Subject\0adm1026 driver port for kernel 2.6.10-rc2 (patch includes driver,\0"
- "Date\0Thu, 19 May 2005 06:25:23 +0000\0"
+ "From\0Justin Thiessen <jthiessen@penguincomputing.com>\0"
+ "Subject\0adm1026 driver port for kernel 2.6.10-rc2 (patch includes driver, patch to Kconfig, and patch to Makefile)\0"
+ "Date\0Tue, 23 Nov 2004 08:52:36 -0800\0"
  "To\0greg@kroah.com"
  " phil@netroedge.com\0"
  "Cc\0khali@linux-fr.org"
@@ -19,8 +19,8 @@
  "module_param_array().  As Jean requested (and as I muttonheadedly ignored)\n"
  "on the last submission, the diff now includes the patches to \n"
  "\n"
- "../drivers/i2c/chips/Makefile\n"
- "../drivers/i2c/chips/Kconfig\n"
+ ".../drivers/i2c/chips/Makefile\n"
+ ".../drivers/i2c/chips/Kconfig\n"
  "\n"
  "Finally (and you've all read this before):\n"
  "\n"
@@ -329,11 +329,11 @@
  "+\n"
  "+/* FAN speed is measured using 22.5kHz clock and counts for 2 pulses\n"
  "+ *   and we assume a 2 pulse-per-rev fan tach signal\n"
- "+ *      22500 kHz * 60 (sec/min) * 2 (pulse) / 2 (pulse/rev) = 1350000\n"
+ "+ *      22500 kHz * 60 (sec/min) * 2 (pulse) / 2 (pulse/rev) == 1350000\n"
  "+ */\n"
  "+#define FAN_TO_REG(val,div)  ((val)<=0 ? 0xff : SENSORS_LIMIT(1350000/((val)*\\\n"
  "+\t(div)),1,254)) \n"
- "+#define FAN_FROM_REG(val,div) ((val)=0?-1:(val)=0xff ? 0 : 1350000/((val)*\\\n"
+ "+#define FAN_FROM_REG(val,div) ((val)==0?-1:(val)==0xff ? 0 : 1350000/((val)*\\\n"
  "+\t(div)))\n"
  "+#define DIV_FROM_REG(val) (1<<(val))\n"
  "+#define DIV_TO_REG(val) ((val)>=8 ? 3 : (val)>=4 ? 2 : (val)>=2 ? 1 : 0)\n"
@@ -504,7 +504,7 @@
  "+\t/* Inform user of chip config */\n"
  "+\tdev_dbg(&client->dev, \"(%d): ADM1026_REG_CONFIG1 is: 0x%02x\\n\",\n"
  "+\t\tclient->id, data->config1);\n"
- "+\tif ((data->config1 & CFG1_MONITOR) = 0) {\n"
+ "+\tif ((data->config1 & CFG1_MONITOR) == 0) {\n"
  "+\t\tdev_dbg(&client->dev, \"(%d): Monitoring not currently \"\n"
  "+\t\t\t\"enabled.\\n\", client->id);\n"
  "+\t}\n"
@@ -542,7 +542,7 @@
  "+\t/* Read and pick apart the existing GPIO configuration */\n"
  "+\tvalue = 0;\n"
  "+\tfor (i = 0;i <= 15;++i) {\n"
- "+\t\tif ((i & 0x03) = 0) {\n"
+ "+\t\tif ((i & 0x03) == 0) {\n"
  "+\t\t\tvalue = adm1026_read_value(client,\n"
  "+\t\t\t\t\tADM1026_REG_GPIO_CFG_0_3 + i/4);\n"
  "+\t\t}\n"
@@ -557,7 +557,7 @@
  "+\t/* If the user asks us to reprogram the GPIO config, then\n"
  "+\t *   do it now.  But only if this is the first ADM1026.\n"
  "+\t */\n"
- "+\tif (client->id = 0\n"
+ "+\tif (client->id == 0\n"
  "+\t    && (gpio_input[0] != -1 || gpio_output[0] != -1\n"
  "+\t\t|| gpio_inverted[0] != -1 || gpio_normal[0] != -1\n"
  "+\t\t|| gpio_fan[0] != -1)) {\n"
@@ -575,7 +575,7 @@
  "+\t *   without first setting a value for pwm1.auto_pwm_min \n"
  "+\t *   will not result in potentially dangerous fan speed decrease.\n"
  "+\t */\n"
- "+\tdata->pwm1.auto_pwm_min%5;\n"
+ "+\tdata->pwm1.auto_pwm_min=255;\n"
  "+\t/* Start monitoring */\n"
  "+\tvalue = adm1026_read_value(client, ADM1026_REG_CONFIG1);\n"
  "+\t/* Set MONITOR, clear interrupt acknowledge and s/w reset */\n"
@@ -683,7 +683,7 @@
  "+\tfor (i = 15, value = 0;i >= 0;--i) {\n"
  "+\t\tvalue <<= 2;\n"
  "+\t\tvalue |= data->gpio_config[i] & 0x03;\n"
- "+\t\tif ((i & 0x03) = 0) {\n"
+ "+\t\tif ((i & 0x03) == 0) {\n"
  "+\t\t\tadm1026_write_value(client,\n"
  "+\t\t\t\t\tADM1026_REG_GPIO_CFG_0_3 + i/4,\n"
  "+\t\t\t\t\tvalue);\n"
@@ -710,17 +710,20 @@
  "+\t\tdev_dbg(&client->dev,\"(%d): Reading sensor values\\n\", \n"
  "+\t\t\tclient->id);\n"
  "+\t\tfor (i = 0;i <= 16;++i) {\n"
- "+\t\t\tdata->in[i] +\t\t\t    adm1026_read_value(client, ADM1026_REG_IN[i]);\n"
+ "+\t\t\tdata->in[i] =\n"
+ "+\t\t\t    adm1026_read_value(client, ADM1026_REG_IN[i]);\n"
  "+\t\t}\n"
  "+\n"
  "+\t\tfor (i = 0;i <= 7;++i) {\n"
- "+\t\t\tdata->fan[i] +\t\t\t    adm1026_read_value(client, ADM1026_REG_FAN(i));\n"
+ "+\t\t\tdata->fan[i] =\n"
+ "+\t\t\t    adm1026_read_value(client, ADM1026_REG_FAN(i));\n"
  "+\t\t}\n"
  "+\n"
  "+\t\tfor (i = 0;i <= 2;++i) {\n"
  "+\t\t\t/* NOTE: temp[] is s8 and we assume 2's complement\n"
  "+\t\t\t *   \"conversion\" in the assignment   */\n"
- "+\t\t\tdata->temp[i] +\t\t\t    adm1026_read_value(client, ADM1026_REG_TEMP[i]);\n"
+ "+\t\t\tdata->temp[i] =\n"
+ "+\t\t\t    adm1026_read_value(client, ADM1026_REG_TEMP[i]);\n"
  "+\t\t}\n"
  "+\n"
  "+\t\tdata->pwm1.pwm = adm1026_read_value(client, \n"
@@ -823,7 +826,7 @@
  "+\n"
  "+\t\tvalue = 0;\n"
  "+\t\tfor (i = 0;i <= 15;++i) {\n"
- "+\t\t\tif ((i & 0x03) = 0) {\n"
+ "+\t\t\tif ((i & 0x03) == 0) {\n"
  "+\t\t\t\tvalue = adm1026_read_value(client,\n"
  "+\t\t\t\t\t    ADM1026_REG_GPIO_CFG_0_3 + i/4);\n"
  "+\t\t\t}\n"
@@ -1051,7 +1054,7 @@
  "+\tint    new_div = data->fan_div[fan];\n"
  "+\n"
  "+\t/* 0 and 0xff are special.  Don't adjust them */\n"
- "+\tif (data->fan_min[fan] = 0 || data->fan_min[fan] = 0xff) {\n"
+ "+\tif (data->fan_min[fan] == 0 || data->fan_min[fan] == 0xff) {\n"
  "+\t\treturn;\n"
  "+\t}\n"
  "+\n"
@@ -1076,7 +1079,7 @@
  "+\n"
  "+\tval = simple_strtol(buf, NULL, 10);\n"
  "+\tnew_div = DIV_TO_REG(val); \n"
- "+\tif (new_div = 0) {\n"
+ "+\tif (new_div == 0) {\n"
  "+\t\treturn -EINVAL;\n"
  "+\t}\n"
  "+\tdown(&data->update_lock);\n"
@@ -1324,7 +1327,7 @@
  "+\tint     val;\n"
  "+\n"
  "+\tval = simple_strtol(buf, NULL, 10);\n"
- "+\tif ((val = 1) || (val=0)) {\n"
+ "+\tif ((val == 1) || (val==0)) {\n"
  "+\t\tdown(&data->update_lock);\n"
  "+\t\tdata->config1 = (data->config1 & ~CFG1_THERM_HOT) | (val << 4);\n"
  "+\t\tadm1026_write_value(client, ADM1026_REG_CONFIG1, \n"
@@ -1544,7 +1547,7 @@
  "+\tstruct adm1026_data *data = i2c_get_clientdata(client);\n"
  "+\tint     val;\n"
  "+\n"
- "+\tif (data->pwm1.enable = 1) {\n"
+ "+\tif (data->pwm1.enable == 1) {\n"
  "+\t\tdown(&data->update_lock);\n"
  "+\t\tval = simple_strtol(buf, NULL, 10);\n"
  "+\t\tdata->pwm1.pwm = PWM_TO_REG(val);\n"
@@ -1568,7 +1571,7 @@
  "+\tdown(&data->update_lock);\n"
  "+\tval = simple_strtol(buf, NULL, 10);\n"
  "+\tdata->pwm1.auto_pwm_min = SENSORS_LIMIT(val,0,255);\n"
- "+\tif (data->pwm1.enable = 2) { /* apply immediately */\n"
+ "+\tif (data->pwm1.enable == 2) { /* apply immediately */\n"
  "+\t\tdata->pwm1.pwm = PWM_TO_REG((data->pwm1.pwm & 0x0f) |\n"
  "+\t\t\tPWM_MIN_TO_REG(data->pwm1.auto_pwm_min)); \n"
  "+\t\tadm1026_write_value(client, ADM1026_REG_PWM, data->pwm1.pwm);\n"
@@ -1599,15 +1602,15 @@
  "+\t\tval = simple_strtol(buf, NULL, 10);\n"
  "+\t\tdata->pwm1.enable = val;\n"
  "+\t\tdata->config1 = (data->config1 & ~CFG1_PWM_AFC)\n"
- "+\t\t\t\t| ((val = 2) ? CFG1_PWM_AFC : 0);\n"
+ "+\t\t\t\t| ((val == 2) ? CFG1_PWM_AFC : 0);\n"
  "+\t\tadm1026_write_value(client, ADM1026_REG_CONFIG1,\n"
  "+\t\t\tdata->config1);\n"
- "+\t\tif (val = 2) {  /* apply pwm1_auto_pwm_min to pwm1 */\n"
+ "+\t\tif (val == 2) {  /* apply pwm1_auto_pwm_min to pwm1 */\n"
  "+\t\t\tdata->pwm1.pwm = PWM_TO_REG((data->pwm1.pwm & 0x0f) |\n"
  "+\t\t\t\tPWM_MIN_TO_REG(data->pwm1.auto_pwm_min)); \n"
  "+\t\t\tadm1026_write_value(client, ADM1026_REG_PWM, \n"
  "+\t\t\t\tdata->pwm1.pwm);\n"
- "+\t\t} else if (!((old_enable = 1) && (val = 1))) {\n"
+ "+\t\t} else if (!((old_enable == 1) && (val == 1))) {\n"
  "+\t\t\t/* set pwm to safe value */\n"
  "+\t\t\tdata->pwm1.pwm = 255;\n"
  "+\t\t\tadm1026_write_value(client, ADM1026_REG_PWM, \n"
@@ -1685,15 +1688,15 @@
  "+\tif (kind <= 0) {\n"
  "+\t\tdev_dbg(&new_client->dev, \"Autodetecting device at %d,0x%02x \"\n"
  "+\t\t\t\"...\\n\", i2c_adapter_id(adapter), address);\n"
- "+\t\tif (company = ADM1026_COMPANY_ANALOG_DEV\n"
- "+\t\t    && verstep = ADM1026_VERSTEP_ADM1026) {\n"
+ "+\t\tif (company == ADM1026_COMPANY_ANALOG_DEV\n"
+ "+\t\t    && verstep == ADM1026_VERSTEP_ADM1026) {\n"
  "+\t\t\tkind = adm1026;\n"
- "+\t\t} else if (company = ADM1026_COMPANY_ANALOG_DEV\n"
- "+\t\t\t&& (verstep & 0xf0) = ADM1026_VERSTEP_GENERIC) {\n"
+ "+\t\t} else if (company == ADM1026_COMPANY_ANALOG_DEV\n"
+ "+\t\t\t&& (verstep & 0xf0) == ADM1026_VERSTEP_GENERIC) {\n"
  "+\t\t\tdev_err(&adapter->dev, \": Unrecognized stepping \"\n"
  "+\t\t\t\t\"0x%02x. Defaulting to ADM1026.\\n\", verstep);\n"
  "+\t\t\tkind = adm1026;\n"
- "+\t\t} else if ((verstep & 0xf0) = ADM1026_VERSTEP_GENERIC) {\n"
+ "+\t\t} else if ((verstep & 0xf0) == ADM1026_VERSTEP_GENERIC) {\n"
  "+\t\t\tdev_err(&adapter->dev, \": Found version/stepping \"\n"
  "+\t\t\t\t\"0x%02x. Assuming generic ADM1026.\\n\",\n"
  "+\t\t\t\tverstep);\n"
@@ -1702,7 +1705,7 @@
  "+\t\t\tdev_dbg(&new_client->dev, \": Autodetection \"\n"
  "+\t\t\t\t\"failed\\n\");\n"
  "+\t\t\t/* Not an ADM1026 ... */\n"
- "+\t\t\tif (kind = 0)  { /* User used force=x,y */\n"
+ "+\t\t\tif (kind == 0)  { /* User used force=x,y */\n"
  "+\t\t\t\tdev_err(&adapter->dev, \"Generic ADM1026 not \"\n"
  "+\t\t\t\t\t\"found at %d,0x%02x.  Try \"\n"
  "+\t\t\t\t\t\"force_adm1026.\\n\",\n"
@@ -1907,4 +1910,4 @@
  "+module_init(sm_adm1026_init);\n"
  +module_exit(sm_adm1026_exit);
 
-a9a134e9c0dec90ce5aed5e8790526c10c13d72be9fc1ec31c3d8cf0b138a380
+3f131fec60add53932fc35d7c4c8515e93e368063a8727d672def34d7795d641

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.