All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manish Lachwani <mlachwani@prometheus.mvista.com>
To: linux-mips@linux-mips.org
Cc: ralf@linux-mips.org
Subject: [PATCH] Comments in the titan ethernet driver for IP header alignment
Date: Tue, 23 Nov 2004 09:14:21 -0800	[thread overview]
Message-ID: <20041123171421.GA30451@prometheus.mvista.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 156 bytes --]

Hi Ralf,

Attached patch puts comments around the section that programs register 0x103C
for IP header alignment. Please review ...

Thanks
Manish Lachwani


[-- Attachment #2: patch-titan-comments --]
[-- Type: text/plain, Size: 916 bytes --]

--- drivers/net/titan_ge.c.orig	2004-11-23 09:00:29.000000000 -0800
+++ drivers/net/titan_ge.c	2004-11-23 09:12:07.000000000 -0800
@@ -1000,6 +1000,17 @@
 	 * driver. This performance drawback existed in the previous
 	 * versions of the silicon
 	 */
+	/*
+	 * The register (0x103c) below has been used to program the 
+	 * chip to do the IP header alignment. The idea was to fix the
+	 * IP header alignment by using existing unused registers,
+	 * so that this feature can be implemented quickly. If these 
+	 * registers are not programmed, then the chip will not align the 
+	 * IP headers and an extra copy would have to be implemented
+	 * in the driver on the Rx side. I am not sure if this 
+	 * has been documented.  
+	 *			- Manish Lachwani (11/23/2004)
+	 */
 	reg_data_1 = TITAN_GE_READ(0x103c + (port_num << 12));
 	reg_data_1 |= 0x40000000;
 	TITAN_GE_WRITE((0x103c + (port_num << 12)), reg_data_1);

             reply	other threads:[~2004-11-23 17:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-23 17:14 Manish Lachwani [this message]
2004-11-23 18:10 ` [PATCH] Comments in the titan ethernet driver for IP header alignment Thomas Koeller
2004-11-23 18:23   ` Manish Lachwani
2004-11-23 18:23     ` Manish Lachwani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041123171421.GA30451@prometheus.mvista.com \
    --to=mlachwani@prometheus.mvista.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.