From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>
Cc: chas@cmf.nrl.navy.mil, linux-atm-general@lists.sourceforge.net,
linux-kernel@vger.kernel.org, jgarzik@pobox.com,
linux-net@vger.kernel.org
Subject: Re: [2.6 patch] small drivers/atm cleanups (fwd)
Date: Wed, 24 Nov 2004 04:02:08 +0100 [thread overview]
Message-ID: <20041124030208.GN2927@stusta.de> (raw)
In-Reply-To: <20041123180931.36f1a733.akpm@osdl.org>
On Tue, Nov 23, 2004 at 06:09:31PM -0800, Andrew Morton wrote:
> Adrian Bunk <bunk@stusta.de> wrote:
> >
> > /*
> > - * This routine will clock the Read_Status_reg function into the X2520
> > - * eeprom, then pull the result from bit 16 of the NicSTaR's General Purpose
> > - * register.
> > - */
> > -
> > -u_int32_t
> > -nicstar_read_eprom_status( virt_addr_t base )
>
> I'd be inclined to whack an #if 0 around functions such as this rather than
> removing them. Someone may come along one day and do some work on the
> driver, and nicstar_read_eprom_status() may prove to be useful to them.
>...
In this case, you also have to #if 0 rdsrtab.
Are you editing my patch or shall I send an updated patch?
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2004-11-24 3:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-24 2:04 [2.6 patch] small drivers/atm cleanups (fwd) Adrian Bunk
2004-11-24 2:09 ` Andrew Morton
2004-11-24 3:02 ` Adrian Bunk [this message]
2004-12-02 0:25 ` [2.6 patch] small drivers/atm cleanups Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041124030208.GN2927@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=chas@cmf.nrl.navy.mil \
--cc=jgarzik@pobox.com \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.