All of lore.kernel.org
 help / color / mirror / Atom feed
From: Domen Puncer <domen@coderock.org>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] Re: ifdef typos: drivers_net_wireless_wavelan_cs.c
Date: Wed, 24 Nov 2004 17:59:09 +0000	[thread overview]
Message-ID: <20041124175909.GA4680@nd47.coderock.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 483 bytes --]

On 24/11/04 18:25 +0100, walter harms wrote:
> Hi Domen,
> nice work :) i never noticed that there are some much typos.
> 
> To avoid namespace polution: IMHO its better to define:
> wavelan_cd_DEBUG_CONFIG_ERRORS (you get the idea)
> stupid long but would avoid conflics with possible other drivers/kernel 
> debug defines.

I disagree:
- there is no "namespace polution", since most defines are local;
- longer defines make it even easier to make typos.


	Domen
> 
> re,
> walter

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

                 reply	other threads:[~2004-11-24 17:59 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041124175909.GA4680@nd47.coderock.org \
    --to=domen@coderock.org \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.