From: Domen Puncer <domen@coderock.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: janitor@sternwelten.at, netdev@oss.sgi.com
Subject: Re: net/ne2k-pci: module_param conversion
Date: Wed, 24 Nov 2004 21:43:48 +0100 [thread overview]
Message-ID: <20041124204348.GB4680@nd47.coderock.org> (raw)
In-Reply-To: <41A4E975.8070102@pobox.com>
On 24/11/04 15:05 -0500, Jeff Garzik wrote:
> janitor@sternwelten.at wrote:
> >@@ -443,8 +435,7 @@ static void ne2k_pci_reset_8390(struct n
> > {
> > unsigned long reset_start_time = jiffies;
> >
> >- if (debug > 1) printk("%s: Resetting the 8390 t=%ld...",
> >- dev->name, jiffies);
> >+ printk(KERN_INFO "%s: Resetting the 8390 t=%ld...", dev->name,
> >jiffies);
>
>
> The rest of the patch looks OK.
>
> This chunk changes behavior, by removing the 'if' test.
This was intended.
Module parameter debug is only used in this test, so i dared removing it.
3 options:
- remove this printk
- don't remove "debug"
- leave patch as is :-)
Let me know of your decision, and i'll send a new patch.
>
> Jeff
prev parent reply other threads:[~2004-11-24 20:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-20 2:45 [patch 1/4] net/ne2k-pci: module_param conversion janitor
2004-11-24 20:05 ` Jeff Garzik
2004-11-24 20:43 ` Domen Puncer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041124204348.GB4680@nd47.coderock.org \
--to=domen@coderock.org \
--cc=janitor@sternwelten.at \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.