All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Valdis.Kletnieks@vt.edu
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: 2.6.10-rc2-mm3-V0.7.31-3 memory leak (was Re: Debugging a memory leak
Date: Fri, 26 Nov 2004 02:14:04 +0100	[thread overview]
Message-ID: <20041126011404.GA4189@elte.hu> (raw)
In-Reply-To: <200411250842.iAP8gC6U011822@turing-police.cc.vt.edu>


* Valdis.Kletnieks@vt.edu <Valdis.Kletnieks@vt.edu> wrote:

> On Tue, 23 Nov 2004 15:38:58 PST, Andrew Morton said:
> > Valdis.Kletnieks@vt.edu wrote:
> > >
> > > Any advice how to shoot this one?
> > 
> > Manfred's slab leak detector:
> 
> Ahh, many thanks - that helped quite a bit.  I tracked down the
> problem - it was in Ingo's VP patch.
> 
> sys_ioperm() would allocate an 8K bitmap and save it in
> ->io_bitmap_ptr. Then when we hit exit_thread(), Ingo's code would
> zero the pointer and *then* pass the freshly-zero'ed pointer to
> kfree() - which of course did nothing particularly interesting.  My
> fix was to save a copy of the pointer to pass to kfree.  Am seeing no
> more leaks.

ah ... good catch - patch applied.

	Ingo

      reply	other threads:[~2004-11-27  2:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-23 19:29 Debugging a memory leak in the 2.6.X kernel - how-to? Valdis.Kletnieks
2004-11-23 19:51 ` William Lee Irwin III
2004-11-23 23:38 ` Andrew Morton
2004-11-25  8:42   ` 2.6.10-rc2-mm3-V0.7.31-3 memory leak (was Re: Debugging a memory leak Valdis.Kletnieks
2004-11-26  1:14     ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041126011404.GA4189@elte.hu \
    --to=mingo@elte.hu \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.