Re: EXPORT_SYMBOL_NOVERS question

[Adrian Bunk <bunk@stusta.de>]

On Mon, Nov 29, 2004 at 09:42:20AM +1100, Rusty Russell wrote:
> On Wed, 2004-11-03 at 00:10 -0800, vlobanov wrote:
> > Hi,
> > 
> > I was looking over the /include/linux/module.h file, and the
> > EXPORT_SYMBOL_NOVERS macro caught my eye. To quote the source:
> > 
> >   /* We don't mangle the actual symbol anymore, so no need for
> >    * special casing EXPORT_SYMBOL_NOVERS.  FIXME: Deprecated */
> >   #define EXPORT_SYMBOL_NOVERS(sym) EXPORT_SYMBOL(sym)
> > 
> > A quick grep through the tree brought up no usage cases for this macro.
> > Is there any reason to keep it around, instead of cutting it out, as the
> > FIXME comment seems to suggest?
> 
> Yep, it's time.
> 
> Rusty.
> 
> Name: Remove EXPORT_SYMBOL_NOVERS
> Status: Trivial
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
> 
> Vadim Lobanov points out that EXPORT_SYMBOL_NOVERS is no longer used;
> in fact, SH still uses it, but once we fix that, the kernel is clean.
> Remove it.
>...

Thaat's true for Linus' tree, but not for -mm.

@David:
arch/frv/kernel/frv_ksyms.c has to be changed.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed