From: Greg KH <greg@kroah.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Roger Luethi <rl@hellgate.ch>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [2.6 PATCH] visor: Make URB limit error more visible
Date: Mon, 29 Nov 2004 16:06:48 -0800 [thread overview]
Message-ID: <20041130000648.GA28436@kroah.com> (raw)
In-Reply-To: <1101661884.16787.28.camel@localhost.localdomain>
On Sun, Nov 28, 2004 at 05:11:25PM +0000, Alan Cox wrote:
> On Iau, 2004-11-25 at 16:16, Roger Luethi wrote:
> > There is only one call to dev_dbg in all of visor.c, the rest is dbg or
> > dev_err. It already bit us once when warnings didn't turn up in a debug
> > log. I would argue that a flood of those warnings will warrant report
> > and inspection anyway (broken app, broken driver, or lame DoS attempt),
> > so I replaced the dev_dbg with dev_err.
> >
> > Signed-off-by: Roger Luethi <rl@hellgate.ch>
>
> Since it is trivially user caused should it not be rate limited or it
> becomes a DoS of its own to the syslog
Agreed, that's why the change I commited doesn't do it this way :)
thanks,
greg k-h
prev parent reply other threads:[~2004-11-30 0:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-16 15:49 [2.6 PATCH] visor: Always do generic_startup Roger Luethi
2004-11-19 17:44 ` Greg KH
2004-11-21 1:23 ` Simon Fowler
2004-11-21 4:08 ` Greg KH
2004-11-21 7:15 ` Simon Fowler
2004-11-22 18:54 ` Greg KH
2004-11-23 19:36 ` [2.6 PATCH] visor: Don't count outstanding URBs twice Roger Luethi
2004-11-23 19:45 ` Greg KH
2004-11-23 20:30 ` Roger Luethi
2004-11-24 0:40 ` Simon Fowler
2004-11-24 23:25 ` Greg KH
2004-11-25 16:16 ` [2.6 PATCH] visor: Make URB limit error more visible Roger Luethi
2004-11-25 18:06 ` Greg KH
2004-11-28 17:11 ` Alan Cox
2004-11-30 0:06 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041130000648.GA28436@kroah.com \
--to=greg@kroah.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=rl@hellgate.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.