From: Roger Luethi <rl@hellgate.ch>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net/via-rhine: convert MODULE_PARM to module_param
Date: Tue, 30 Nov 2004 15:03:10 +0100 [thread overview]
Message-ID: <20041130140309.GA6568@k3.hellgate.ch> (raw)
In-Reply-To: <Pine.LNX.4.61.0411300053190.3432@dragon.hygekrogen.localhost>
On Tue, 30 Nov 2004 00:58:58 +0100, Jesper Juhl wrote:
> These warnings told me that it was time to move to module_param() :)
>
> drivers/net/via-rhine.c:229: warning: `MODULE_PARM_' is deprecated (declared at include/linux/module.h:562)
> drivers/net/via-rhine.c:230: warning: `MODULE_PARM_' is deprecated (declared at include/linux/module.h:562)
> drivers/net/via-rhine.c:231: warning: `MODULE_PARM_' is deprecated (declared at include/linux/module.h:562)
>
> So I made this small patch to do so.
> Compile and boot tested on my box, and it seems to work just fine, the
> module works perfectly with my via-rhine card, and the parameters are
> exposed through sysfs as expected :
IIRC Jeff has already queued such a patch for 2.6.11. Thanks, though.
Roger
next prev parent reply other threads:[~2004-11-30 14:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-29 23:58 [PATCH] net/via-rhine: convert MODULE_PARM to module_param Jesper Juhl
2004-11-30 14:03 ` Roger Luethi [this message]
2004-11-30 21:44 ` Jesper Juhl
2004-11-30 22:04 ` Roger Luethi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041130140309.GA6568@k3.hellgate.ch \
--to=rl@hellgate.ch \
--cc=juhl-lkml@dif.dk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.