All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave C Boutcher <sleddog@us.ibm.com>
To: linux-scsi@vger.kernel.org
Subject: Re: [patch 2/4] ibmvscsi.c: limit size of I/O requests
Date: Tue, 30 Nov 2004 09:29:16 -0600	[thread overview]
Message-ID: <20041130152916.GA7639@cs.umn.edu> (raw)
In-Reply-To: <20041130075457.GD10450@suse.de>

On Tue, Nov 30, 2004 at 08:54:58AM +0100, Jens Axboe wrote:
> On Mon, Nov 29 2004, Dave C Boutcher wrote:
> > Description: Limit the size of I/O requests sent by the 
> > ibmvscsi adapter.  With better I/O scheduling (and thus larger
> > requests) we were breaking some servers.
> 
> Nack, why can't you use /dev/block/xxx/queue/max_sectors_kb to control
> this?

The basic function of this patch is to set host->max_sectors based
on information from the SCSI target.

There is a default value because two of the existing target implementations
(there are three) don't set the value.

I confess to making the default value a module parameter because I
took a SWAG at the correct value.  I COULD remove the module
parameter part of this patch, though if someone actually cares enough
about performance to tweak it, modprobe.conf seems like a nice place to
set it.

-- 
Dave Boutcher

  reply	other threads:[~2004-11-30 15:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-29 20:31 [patch 2/4] ibmvscsi.c: limit size of I/O requests Dave C Boutcher
2004-11-30  7:54 ` Jens Axboe
2004-11-30 15:29   ` Dave C Boutcher [this message]
2004-12-02 20:13     ` Jens Axboe
2004-12-31 17:47 ` [patch] ibmvscsi.c: limit size of I/O requests, updated Dave C Boutcher
2004-12-31 19:10   ` James Bottomley
2004-12-31 19:19     ` Dave C Boutcher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041130152916.GA7639@cs.umn.edu \
    --to=sleddog@us.ibm.com \
    --cc=boutcher@cs.umn.edu \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.