Re: [PATCH][PPC32] Fix gianfar netdriver oops when using bootp...

[Gerhard Jaeger <g.jaeger@sysgo.com>]

On Thursday 02 December 2004 09:14, Kumar Gala wrote:
> Fun with mailers.  Try this url:
>=20
> http://tinyurl.com/6skww

Thanks that works (I mean the URL ;)
I have not tested, but this might will work, as I noticed, that when addidi=
onally
CONFIG_RARP is enabled, there are also no problems.

Anyway, I'll test ASAP and will tell you the results.

Thanx so far,
Gerhard

>=20
> - kumar
>=20
> On Dec 2, 2004, at 2:07 AM, Gerhard Jaeger wrote:
>=20
> > Hi,
> >
> > On Wednesday 01 December 2004 23:19, Kumar Gala wrote:
> >  > There is some belief that the following patch should fix the issue:
> >  >
> > > http://linux.bkbits.net:8080/linux-2.5/cset@1.2249.2.2?=20
> > nav=3Dindex.html|ChangeSet@-3d
> >  >
> > > I would be interested to know if this helps w/o your patch.
> >
> > I'd like to cross-check this, but are you sure, you're referencing the=
=20
> > correct
> >  changeset? Currently I only got:
> >  Error 500
> >  Unable to find revision 1.2249.2.2
> >
> > Gerhard
> >
> > >
> > > - kumar
> >  >
> > > On Dec 1, 2004, at 10:07 AM, Gerhard Jaeger wrote:
> >  >
> > > > Hi,
> >  > >
> >  > > this patch fixes an issue, that occurs on my MPC8541CDS, when=20
> > trying to
> >  > >=A0 use bootp to get the IP parameters. It seems, that the patch=20
> > only=A0
> >  > > cures
> >  > >=A0 the symptom but obviously not the cause ;)
> >  > >
> >  > > Signed-off-by: Gerhard Jaeger <gjaeger@sysgo.com>
> > > >
> >  > > --- linux-2.6.10-rc2-mm4/drivers/net/gianfar.c.orig=A0=A0=A0=A0=20
> > 2004-11-15=A0
> > > > 02:26:34.000000000 +0100
> >  > >=A0 +++ linux-2.6.10-rc2-mm4/drivers/net/gianfar.c=A0 2004-12-01=A0
> > > > 17:00:19.000000000 +0100
> >  > >=A0 @@ -1477,6 +1477,9 @@ static void gfar_phy_change(void *data)
> >  > >=A0 =A0=A0=A0=A0=A0=A0=A0 struct gfar_private *priv =3D netdev_priv=
(dev);
> > > > =A0=A0=A0=A0=A0=A0=A0 int result =3D 0;
> >  > >=A0 =A0
> >  > >=A0 +=A0=A0=A0=A0=A0=A0 if( !priv->mii_info->phyinfo )
> >  > >=A0 +=A0=A0=A0=A0=A0=A0 =A0=A0=A0=A0=A0=A0=A0 return;
> >  > >=A0 +
> >  > >=A0 =A0=A0=A0=A0=A0=A0=A0 /* Delay to give the PHY a chance to chan=
ge the
> >  > >=A0 =A0=A0=A0=A0=A0=A0=A0=A0 * register state */
> > > >=A0 =A0=A0=A0=A0=A0=A0=A0 msleep(1);
> >  >
> > >
>=20
>=20