From: Christoph Hellwig <hch@infradead.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@zip.com.au>
Subject: Re: [PATCH] Neaten page virtual choice
Date: Thu, 2 Dec 2004 18:35:06 +0000 [thread overview]
Message-ID: <20041202183506.GA32283@infradead.org> (raw)
In-Reply-To: <20041202162621.GM5752@parcelfarce.linux.theplanet.co.uk>
> #if defined(WANT_PAGE_VIRTUAL)
> -#define page_address(page) ((page)->virtual)
> -#define set_page_address(page, address) \
> + #define page_address(page) ((page)->virtual)
> + #define set_page_address(page, address) \
urgg, this is a horrible non-standard indentation.
If you look at other kernel source you see either:
- no indentation inside #ifdef at all (seems like most of the source)
- indentation after the leading #
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2004-12-02 18:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-02 16:26 [PATCH] Neaten page virtual choice Matthew Wilcox
2004-12-02 18:35 ` Christoph Hellwig [this message]
2004-12-02 18:42 ` Martin J. Bligh
2004-12-02 19:12 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041202183506.GA32283@infradead.org \
--to=hch@infradead.org \
--cc=akpm@zip.com.au \
--cc=linux-mm@kvack.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.