From: Parag Warudkar <kernel-stuff@comcast.net>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Manfred Spraul <manfred@colorfullife.com>,
akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Document kfree and vfree NULL usage (resend)
Date: Sun, 5 Dec 2004 15:38:35 -0500 [thread overview]
Message-ID: <200412051538.42498.kernel-stuff@comcast.net> (raw)
In-Reply-To: <1102278101.19406.0.camel@localhost>
[-- Attachment #1: Type: text/plain, Size: 1264 bytes --]
On Sunday 05 December 2004 03:21 pm, Pekka Enberg wrote:
> On Sun, 2004-12-05 at 17:59 +0100, Manfred Spraul wrote:
> > And you are right: for vfree, it's "must not be called". I'll send a
> > separate patch. Or Andrew could just change it directly.
>
> Please do it for vunmap() also.
>
> Pekka
>
>
Ok. Patch for vfree and vunmap below. Please discard previous patch for kfree().
Parag
Signed-off-by: Parag Warudkar <kernel-stuff@comcast.net>
--- linux-mod/mm/vmalloc.c.orig 2004-12-05 12:40:50.699631616 -0500
+++ linux-mod/mm/vmalloc.c 2004-12-05 15:33:26.344334328 -0500
@@ -340,7 +340,7 @@ void __vunmap(void *addr, int deallocate
* Free the virtually contiguous memory area starting at @addr, as
* obtained from vmalloc(), vmalloc_32() or __vmalloc().
*
- * May not be called in interrupt context.
+ * Must not be called in interrupt context.
*/
void vfree(void *addr)
{
@@ -358,7 +358,7 @@ EXPORT_SYMBOL(vfree);
* Free the virtually contiguous memory area starting at @addr,
* which was created from the page array passed to vmap().
*
- * May not be called in interrupt context.
+ * Must not be called in interrupt context.
*/
void vunmap(void *addr)
{
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2004-12-05 20:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-03 19:48 [PATCH] Document kfree and vfree NULL usage (resend) Pekka Enberg
2004-12-05 15:33 ` Manfred Spraul
2004-12-05 16:05 ` Kernel Stuff
2004-12-05 16:59 ` Manfred Spraul
2004-12-05 17:44 ` Kernel Stuff
2004-12-05 17:57 ` Manfred Spraul
2004-12-05 18:12 ` Parag Warudkar
2004-12-05 20:29 ` Pekka Enberg
[not found] ` <200412051648.08283.kernel-stuff@comcast.net>
2004-12-06 8:09 ` Pekka Enberg
2004-12-05 20:21 ` Pekka Enberg
2004-12-05 20:38 ` Parag Warudkar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200412051538.42498.kernel-stuff@comcast.net \
--to=kernel-stuff@comcast.net \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.