All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Nigel Cunningham <ncunningham@linuxmail.org>,
	mjg59@srcf.ucam.org,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	Linux-pm mailing list <linux-pm@lists.osdl.org>
Subject: Re: [linux-pm] swsusp-bigdiff: power-managment changes that are waiting in my tree
Date: Mon, 6 Dec 2004 00:24:40 +0100	[thread overview]
Message-ID: <20041205232440.GA1490@elf.ucw.cz> (raw)
In-Reply-To: <1102284611.11763.97.camel@gaston>

Hi!

> > +#These are not really events sent:
> > +#
> > +#System fully on -- device is working normally; this is probably never
> > +#passed to suspend() method... event = ON, flags = 0
> > +#
> > +#Ready after resume -- userland is now running, again. Time to free any
> > +#memory you ate during prepare to suspend... event = ON, flags =
> > +#READY_AFTER_RESUME
> 
> I think we need to add the pm_message_t to resume. You are already
> "fixing" everybody to change u32 -> pm_message_t, so it  shouldn't be
> that bad to add this too.

We need to add pm_message_t to resume, I agree about that, but yes, it
would be quite bad if I added this, too.

All changes I'm doing are "break nothing", because pm_message_t is
typedefed to u32 for now. Therefore they can be safely merged in any
order etc...

For the documentation changes... I already rewrote that twice. I'm not
native english speaker and I need some sleep now. If you send me
nicely-looking diff, I'm likely to accept it :-).
								Pavel
-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!

  reply	other threads:[~2004-12-05 23:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-05 21:49 swsusp-bigdiff: power-managment changes that are waiting in my tree Pavel Machek
2004-12-05 22:10 ` [linux-pm] " Benjamin Herrenschmidt
2004-12-05 23:24   ` Pavel Machek [this message]
2004-12-05 23:30     ` Benjamin Herrenschmidt
2004-12-05 23:32       ` Pavel Machek
2004-12-05 23:50         ` Benjamin Herrenschmidt
2004-12-05 23:31   ` Pavel Machek
2004-12-05 23:47     ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041205232440.GA1490@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.osdl.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=ncunningham@linuxmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.