From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261774AbULGGpG (ORCPT ); Tue, 7 Dec 2004 01:45:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261775AbULGGpF (ORCPT ); Tue, 7 Dec 2004 01:45:05 -0500 Received: from fw.osdl.org ([65.172.181.6]:27037 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S261774AbULGGo5 (ORCPT ); Tue, 7 Dec 2004 01:44:57 -0500 Date: Mon, 6 Dec 2004 22:44:41 -0800 From: Andrew Morton To: Thomas Cataldo Cc: linux-kernel@vger.kernel.org, netdev@oss.sgi.com, tgraf@suug.ch, "David S. Miller" Subject: Re: Hard freeze with 2.6.10-rc3 and QoS, worked fine with 2.6.9 Message-Id: <20041206224441.628e7885.akpm@osdl.org> In-Reply-To: <1102380430.6103.6.camel@buffy> References: <1102380430.6103.6.camel@buffy> X-Mailer: Sylpheed version 0.9.7 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Thomas Cataldo wrote: > > Tonight I upgraded to 2.6.10-rc3. Everything was fine until I started > wondershaper to setup my Qos rules : > > wondershaper eth0 255 16 > > And the machine freezed hard. No magic sysrq working, no oops in my > logs. > > The computer is an x86 smp (dual p3) > > wondershaper was working fine with 2.6.9. Me too, with your .config: Using http://lartc.org/wondershaper/wondershaper-1.1a.tar.gz vmm:/home/akpm/wondershaper-1.1a# ./wshaper eth0 255 16 u32 classifier Perfomance counters on input device check on Actions configured Unable to handle kernel NULL pointer dereference at virtual address 00000000 printing eip: c0290b58 *pde = 00000000 Oops: 0002 [#1] SMP Modules linked in: police sch_ingress cls_u32 sch_sfq sch_cbq usbcore CPU: 1 EIP: 0060:[] Not tainted VLI EFLAGS: 00010206 (2.6.10-rc3) EIP is at _spin_lock_bh+0x10/0x20 eax: cf690000 ebx: ce0d4d80 ecx: 00000008 edx: 00000000 esi: cf691ba0 edi: 00000000 ebp: 00000000 esp: cf691b48 ds: 007b es: 007b ss: 0068 Process tc (pid: 2743, threadinfo=cf690000 task=cf07b520) Stack: c02372ab ce0d4d80 cd4d8800 cebd1c40 ce0d4d80 c0237346 ce0d4d80 00000008 00000000 00000000 00000000 cf691ba0 cf691ba0 c02478d6 ce0d4d80 00000008 00000000 cf691ba0 ce0d4d80 cf6a6070 30960094 cec44380 00000000 00019000 Call Trace: [] gnet_stats_start_copy_compat+0x1b/0x98 [] gnet_stats_start_copy+0x1e/0x24 [] tcf_action_copy_stats+0x26/0xa0 [] tcf_action_dump_old+0x36/0x3c [] u32_dump+0x2c8/0x344 [cls_u32] [] u32_dump+0x2fa/0x344 [cls_u32] [] tcf_fill_node+0x11d/0x170 [] tfilter_notify+0x50/0xa0 [] tc_ctl_tfilter+0x542/0x570 [] rtnetlink_rcv+0x23d/0x360 [] netlink_data_ready+0x1c/0x54 [] netlink_sendskb+0x21/0x40 [] netlink_unicast+0xe3/0xec [] netlink_sendmsg+0x27c/0x28c [] sock_sendmsg+0xd5/0xf8 [] sock_sendmsg+0xd5/0xf8 [] copy_from_user+0x30/0x60 [] copy_from_user+0x30/0x60 [] autoremove_wake_function+0x0/0x40 [] sys_sendmsg+0x18f/0x1f4 [] handle_mm_fault+0x80/0x11c [] do_page_fault+0x1a3/0x554 [] copy_from_user+0x30/0x60 [] sys_socketcall+0x1d8/0x1f4 [] sysenter_past_esp+0x52/0x71 Code: 3a 00 7e f9 fa eb e9 c3 8d 76 00 fa f0 fe 08 79 09 f3 90 80 38 00 7e f9 eb f2 c3 89 c2 b8 00 e0 ff ff 21 e0 81 <0>Kernel panic - not syncing: Fatal exception in interrupt Somehow I don't think this is because "Performance" was misspelled ;) tcf_act_hdr.stats_lock is NULL in tcf_action_copy_stats()