All of lore.kernel.org
 help / color / mirror / Atom feed
From: mhoffman@lightlink.com (Mark M. Hoffman)
To: lm-sensors@vger.kernel.org
Subject: Data block transactions fail on i2c-i801 controller?
Date: Thu, 19 May 2005 06:25:26 +0000	[thread overview]
Message-ID: <20041207164142.GC5295@jupiter.solarsys.private> (raw)
In-Reply-To: <13938324.1095712833883.JavaMail.root@scooter.psp.pas.earthlink.net>

Hi MDS, David:

* Mark D. Studebaker <mds4@verizon.net> [2004-12-07 10:14:54 -0500]:
> wow, a week turned into 2 1/2 months :)
> sorry for the delay.
> 
> There is no problem in the i801 block code.
> The bug is in the lm93 driver. 
> There is no check for success in lm93_read_block().
> Therefore every block transaction is called 5 times (MAX_RETRIES).
> What should have been 9 transactions turned into 45.
> Rather obvious from the logs (which are still at the link David posted - 
> thanks David).
> I'll fix lm93.

Yikes.

Yes it is obvious.  I'm eating my foot as I type this... or as my boss would
say, working on a case of athlete's tongue. :)  I'm sorry about that Mark -
thanks for fixing it.

David: please let us know how that works out when you get the chance.

Regards,

-- 
Mark M. Hoffman
mhoffman@lightlink.com

  parent reply	other threads:[~2005-05-19  6:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-19  6:25 Data block transactions fail on i2c-i801 controller? David Knierim
2005-05-19  6:25 ` David Knierim
2005-05-19  6:25 ` Mark M. Hoffman
2005-05-19  6:25 ` Mark M. Hoffman
2005-05-19  6:25 ` Jean Delvare
2005-05-19  6:25 ` Mark Studebaker
2005-05-19  6:25 ` Jean Delvare
2005-05-19  6:25 ` Mark M. Hoffman [this message]
2005-05-19  6:25 ` Mark Studebaker
2005-05-19  6:25 ` David Knierim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041207164142.GC5295@jupiter.solarsys.private \
    --to=mhoffman@lightlink.com \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.