[PATCH] GeForce 5200 on rivafb

[Lucas Correia Villa Real <lucasvr@gobolinux.org>]

[-- Attachment #1: Type: text/plain, Size: 732 bytes --]

Hi,

I was trying to figure out why my GeForce FX 5200 wasn't being recognized by 
rivafb, when I saw that its ID was not being included by the driver.

The following patch (against 2.6.10-rc3) allows it to compile and switch to 
graphics mode successfully.

Just a note: the README file shipped with the NVIDIA driver has a complete 
list of device ID's. While it's easy to add them all into riva.c and 
pci_ids.h, I'm not very sure if it's okay to flood them with #defines and by 
increasing heavily the rivafb_pci_tbl table.

Is it ok to do that, or were you waiting to get a feedback from users from 
those cards first? I can provide a patch to include all the missing cards if 
there's no problem on doing that.

Thanks!
Lucas

[-- Attachment #2: rivafb-geforcefx.patch --]
[-- Type: text/x-diff, Size: 1793 bytes --]

diff -X dontdiff-2.6 -Nur 2.6.10-rc3-vanilla/drivers/video/riva/fbdev.c 2.6.10-rc3-lucasvr/drivers/video/riva/fbdev.c
--- 2.6.10-rc3-vanilla/drivers/video/riva/fbdev.c	2004-12-07 09:58:14.000000000 -0200
+++ 2.6.10-rc3-lucasvr/drivers/video/riva/fbdev.c	2004-12-07 22:45:52.000000000 -0200
@@ -192,6 +192,10 @@
 	  PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
 	{ PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_QUADRO4_700XGL,
 	  PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
+	{ PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_GEFORCE_FX_5200_ULTRA,
+	  PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
+	{ PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_GEFORCE_FX_5200,
+	  PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
 	{ PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_GEFORCE_FX_GO_5200,
 	  PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
 	{ 0, } /* terminate list */
@@ -1876,6 +1880,8 @@
 		case 0x0300:   /* GeForceFX 5800 */
 		case 0x0310:   /* GeForceFX 5600 */
 		case 0x0320:   /* GeForceFX 5200 */
+		case 0x0321:   /* GeForceFX 5200 Ultra */
+		case 0x0322:   /* GeForceFX 5200 */
 		case 0x0330:   /* GeForceFX 5900 */
 		case 0x0340:   /* GeForceFX 5700 */
 		     arch =  NV_ARCH_30;
diff -X dontdiff-2.6 -Nur 2.6.10-rc3-vanilla/include/linux/pci_ids.h 2.6.10-rc3-lucasvr/include/linux/pci_ids.h
--- 2.6.10-rc3-vanilla/include/linux/pci_ids.h	2004-12-07 09:58:25.000000000 -0200
+++ 2.6.10-rc3-lucasvr/include/linux/pci_ids.h	2004-12-07 22:45:29.000000000 -0200
@@ -1144,6 +1144,8 @@
 #define PCI_DEVICE_ID_NVIDIA_QUADRO4_900XGL	0x0258
 #define PCI_DEVICE_ID_NVIDIA_QUADRO4_750XGL	0x0259
 #define PCI_DEVICE_ID_NVIDIA_QUADRO4_700XGL	0x025B
+#define PCI_DEVICE_ID_NVIDIA_GEFORCE_FX_5200_ULTRA 0x0321
+#define PCI_DEVICE_ID_NVIDIA_GEFORCE_FX_5200    0x0322
 #define PCI_DEVICE_ID_NVIDIA_GEFORCE_FX_GO_5200	0x0329
 
 #define PCI_VENDOR_ID_IMS		0x10e0