From: Adrian Bunk <bunk@stusta.de>
To: Ron Murray <rjmx@rjmx.net>
Cc: linux-kernel@vger.kernel.org, Vojtech Pavlik <vojtech@suse.cz>,
linux-input@atrey.karlin.mff.cuni.cz
Subject: Re: [PATCH] CS461x gameport code isn't being included in build
Date: Wed, 8 Dec 2004 13:51:34 +0100 [thread overview]
Message-ID: <20041208125133.GT5496@stusta.de> (raw)
In-Reply-To: <41B237C6.9030404@rjmx.net>
On Sat, Dec 04, 2004 at 05:18:46PM -0500, Ron Murray wrote:
> I've found a typo in drivers/input/gameport/Makefile in kernel
> 2.6.9 which effectively prevents the CS461x gameport code from
> being included. Here's the diff:
>
> --- linux-2.6.9/drivers/input/gameport/Makefile.orig 2004-10-18
> 17:53:06.000000000 -0400
> +++ linux-2.6.9/drivers/input/gameport/Makefile 2004-12-04
> 16:51:12.000000000 -0500
> @@ -5,7 +5,7 @@
> # Each configuration option enables a list of files.
>
> obj-$(CONFIG_GAMEPORT) += gameport.o
> -obj-$(CONFIG_GAMEPORT_CS461X) += cs461x.o
> +obj-$(CONFIG_GAMEPORT_CS461x) += cs461x.o
> obj-$(CONFIG_GAMEPORT_EMU10K1) += emu10k1-gp.o
> obj-$(CONFIG_GAMEPORT_FM801) += fm801-gp.o
> obj-$(CONFIG_GAMEPORT_L4) += lightning.o
>
> Note: the change is to a lower-case 'x' in
> 'CONFIG_GAMEPORT_CS461x'. It's hard to see.
>
> Kconfig in the same directory has
>
> >> config GAMEPORT_CS461x
> >> tristate "Crystal SoundFusion gameport support"
> >> depends on GAMEPORT
>
> This patch brings the Makefile into line with the spelling in
> Kconfig.
>...
Good catch.
But by convention, the names of config variables in the kernel are all
uppercase.
I'm therefore suggesting the patch below fixing this bug the other way.
> .....Ron
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-rc2-mm4-full/drivers/input/gameport/Kconfig.old 2004-12-08 13:45:53.000000000 +0100
+++ linux-2.6.10-rc2-mm4-full/drivers/input/gameport/Kconfig 2004-12-08 13:46:06.000000000 +0100
@@ -84,7 +84,7 @@
tristate "ForteMedia FM801 gameport support"
depends on GAMEPORT
-config GAMEPORT_CS461x
+config GAMEPORT_CS461X
tristate "Crystal SoundFusion gameport support"
depends on GAMEPORT
next prev parent reply other threads:[~2004-12-08 12:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-04 22:18 [PATCH] CS461x gameport code isn't being included in build Ron Murray
2004-12-05 12:53 ` Cal Peake
2004-12-08 12:51 ` Adrian Bunk [this message]
[not found] <200501040609.j0469qtl004738@hera.kernel.org>
2005-01-06 12:41 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041208125133.GT5496@stusta.de \
--to=bunk@stusta.de \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=rjmx@rjmx.net \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.