From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>
Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org
Subject: [2.6 patch] AFS: afs_voltypes isn't always required (fwd)
Date: Sat, 11 Dec 2004 17:54:51 +0100 [thread overview]
Message-ID: <20041211165451.GT22324@stusta.de> (raw)
The patch forwarded below still applies and compiles against
2.6.10-rc2-mm4.
Please apply.
----- Forwarded message from Adrian Bunk <bunk@stusta.de> -----
Date: Sat, 30 Oct 2004 23:38:11 +0200
From: Adrian Bunk <bunk@stusta.de>
To: dhowells@redhat.com
Cc: linux-kernel@vger.kernel.org
Subject: [2.6 patch] AFS: afs_voltypes isn't always required
afs_voltypes is only used #ifdef __KDEBUG, and even then it doesn't has
to be a global symbol.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-rc1-mm2-full/fs/afs/types.h.old 2004-10-30 20:42:02.000000000 +0200
+++ linux-2.6.10-rc1-mm2-full/fs/afs/types.h 2004-10-30 23:22:03.000000000 +0200
@@ -26,8 +26,6 @@
AFSVL_BACKVOL, /* backup volume */
} __attribute__((packed)) afs_voltype_t;
-extern const char *afs_voltypes[];
-
typedef enum {
AFS_FTYPE_INVALID = 0,
AFS_FTYPE_FILE = 1,
--- linux-2.6.10-rc1-mm2-full/fs/afs/volume.c.old 2004-10-30 20:41:43.000000000 +0200
+++ linux-2.6.10-rc1-mm2-full/fs/afs/volume.c 2004-10-30 23:20:41.000000000 +0200
@@ -24,7 +24,9 @@
#include "vlclient.h"
#include "internal.h"
-const char *afs_voltypes[] = { "R/W", "R/O", "BAK" };
+#ifdef __KDEBUG
+static const char *afs_voltypes[] = { "R/W", "R/O", "BAK" };
+#endif
#ifdef CONFIG_AFS_FSCACHE
static fscache_match_val_t afs_volume_cache_match(void *target,
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
----- End forwarded message -----
next reply other threads:[~2004-12-11 16:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-11 16:54 Adrian Bunk [this message]
2004-12-13 14:52 ` [2.6 patch] AFS: afs_voltypes isn't always required (fwd) David Howells
2004-12-18 0:33 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041211165451.GT22324@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.