All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: "Randy.Dunlap" <rddunlap@osdl.org>, Andrew Morton <akpm@osdl.org>,
	Linus Torvalds <torvalds@osdl.org>,
	SCSI Mailing List <linux-scsi@vger.kernel.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [BK PATCH] SCSI -rc fixes for 2.6.10-rc3
Date: Sat, 11 Dec 2004 18:22:03 +0100	[thread overview]
Message-ID: <20041211172202.GD3033@suse.de> (raw)
In-Reply-To: <1102776407.5688.4.camel@mulgrave>

On Sat, Dec 11 2004, James Bottomley wrote:
> On Fri, 2004-12-10 at 14:55 -0800, Randy.Dunlap wrote:
> > I have a drive, but I'm not near a highmem machine atm.
> > I can test it next week if no one else does so.
> 
> So would you be amenable to fixing it properly?  It looks like what
> needs to happen is that it needs to accept its commands into the
> scsi_pointer with page and offset (scsi_pointer doesn't have these
> fields, but you could probably cast in ptr and dma_handle).  Then do a
> kmap/kunmap around imm_in() and imm_out() when it's operating on
> SCp.ptr.

Yep, that would be the optimal. But still, given the hardware, I feel
the hacky workaround would be acceptable. If Randy wants to fix it
properly being able to test it, perfect.

-- 
Jens Axboe


  reply	other threads:[~2004-12-11 17:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-10  3:56 [BK PATCH] SCSI -rc fixes for 2.6.10-rc3 James Bottomley
2004-12-10 20:11 ` Jens Axboe
2004-12-10 22:55   ` Randy.Dunlap
2004-12-11 14:46     ` James Bottomley
2004-12-11 17:22       ` Jens Axboe [this message]
2004-12-11 17:33         ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041211172202.GD3033@suse.de \
    --to=axboe@suse.de \
    --cc=James.Bottomley@SteelEye.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=rddunlap@osdl.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.