From: Jan-Benedict Glaw <jbglaw@lug-owl.de>
To: Ed L Cashin <ecashin@coraid.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ATA over Ethernet driver for 2.6.9 (with changes)
Date: Mon, 13 Dec 2004 22:23:01 +0100 [thread overview]
Message-ID: <20041213212301.GI16958@lug-owl.de> (raw)
In-Reply-To: <87k6rmuqu4.fsf@coraid.com>
[-- Attachment #1: Type: text/plain, Size: 1490 bytes --]
On Mon, 2004-12-13 11:04:51 -0500, Ed L Cashin <ecashin@coraid.com>
wrote in message <87k6rmuqu4.fsf@coraid.com>:
[...]
Impressive list of changes. I'm thinking about implementing a userland
server for AoE. Is there a formal protocol specification available?
Though, I'd use the block driver's sources to reverse engineer it, but
for interoperability purposes, it would probably be better to start off
a specification than an implementation.
. o O (...and I'd love to get my hands on a real hardware device)
> diff -urNp linux-2.6.9/drivers/block/aoe/aoecmd.c linux-2.6.9-aoe/drivers/block/aoe/aoecmd.c
> --- linux-2.6.9/drivers/block/aoe/aoecmd.c 1969-12-31 19:00:00.000000000 -0500
> +++ linux-2.6.9-aoe/drivers/block/aoe/aoecmd.c 2004-12-13 10:53:19.000000000 -0500
> +static void
> +aoecmd_ata_rw(struct Aoedev *d, struct Frame *f)
> +{
[...]
> + if (d->flags & DEVFL_EXT) {
> + ah->aflags |= AOEAFL_EXT;
> + ah->lba4 = sector >>= 8;
> + ah->lba5 = sector >>= 8;
> + } else {
> + extbit = 0;
> + ah->lba3 &= 0x0f;
> + ah->lba3 |= 0xe0; /* LBA bit + obsolete 0xa0 */
This comment doesn't match it's code.
MfG, JBG
--
Jan-Benedict Glaw jbglaw@lug-owl.de . +49-172-7608481 _ O _
"Eine Freie Meinung in einem Freien Kopf | Gegen Zensur | Gegen Krieg _ _ O
fuer einen Freien Staat voll Freier Bürger" | im Internet! | im Irak! O O O
ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA));
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-12-13 21:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-13 16:04 [PATCH] ATA over Ethernet driver for 2.6.9 (with changes) Ed L Cashin
2004-12-13 20:19 ` Jens Axboe
2004-12-14 13:39 ` Ed L Cashin
2004-12-14 13:52 ` Jens Axboe
2004-12-13 21:23 ` Jan-Benedict Glaw [this message]
2004-12-14 20:39 ` Ed L Cashin
2004-12-13 21:54 ` Greg KH
2004-12-14 13:50 ` Ed L Cashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041213212301.GI16958@lug-owl.de \
--to=jbglaw@lug-owl.de \
--cc=ecashin@coraid.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.