All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Andrea Arcangeli <andrea@suse.de>
Cc: Hugh Dickins <hugh@veritas.com>, Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org
Subject: Re: kernel BUG at mm/rmap.c:480 in 2.6.10-rc3-bk7
Date: Wed, 15 Dec 2004 15:41:41 -0800	[thread overview]
Message-ID: <20041215234141.GA9268@kroah.com> (raw)
In-Reply-To: <20041215224826.GC28286@dualathlon.random>

On Wed, Dec 15, 2004 at 11:48:26PM +0100, Andrea Arcangeli wrote:
> On Wed, Dec 15, 2004 at 08:03:43PM +0100, Andrea Arcangeli wrote:
> > +			if (page->mapping)
> > +				page_remove_rmap(page);
> 
> This had to be page_mapping, since I believe the page->mapping can go
> away with the truncate while the page is still being mapped.
> 
> The rule is that if a page must not be accounted it will never be
> accounted and page_mapping will be always 0. If it has been accounted
> previously, then it must be unaccounted too. This worked fine so far.
> 
> Plus I noticed other goodness that got dropped in the same area from my
> original 2.6.5 patches, and I resurrected those too in sync with SP1
> (I'm talking about the fork path).
>  
> So here an updated patch, please give this one a spin.

No oops with this patch or odd messages in the syslog!  It works fine
for me, thanks a lot.

I'll let the mm developers battle it out to determine if this is a good
fix or not :)

thanks,

greg k-h

  reply	other threads:[~2004-12-15 23:41 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-14 16:45 kernel BUG at mm/rmap.c:480 in 2.6.10-rc3-bk7 Greg KH
2004-12-14 23:26 ` Hugh Dickins
2004-12-15  0:10   ` Nick Piggin
2004-12-15  0:19   ` Greg KH
2004-12-15  1:11     ` Greg KH
2004-12-15 17:23       ` Hugh Dickins
2004-12-15 17:58         ` Greg KH
2004-12-15 18:48           ` Hugh Dickins
2004-12-15 22:22             ` Hugh Dickins
2004-12-15 22:33             ` Dave Airlie
2004-12-15 23:19               ` Greg KH
2004-12-15 19:03           ` Andrea Arcangeli
2004-12-15 22:48             ` Andrea Arcangeli
2004-12-15 23:41               ` Greg KH [this message]
2004-12-16  5:18                 ` Hugh Dickins
2004-12-16 14:28                   ` Andrea Arcangeli
2004-12-16 17:03                     ` Hugh Dickins
2004-12-15  0:43   ` Andrea Arcangeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041215234141.GA9268@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@osdl.org \
    --cc=andrea@suse.de \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.