All of lore.kernel.org
 help / color / mirror / Atom feed
From: Werner Almesberger <werner@almesberger.net>
To: Con Kolivas <kernel@kolivas.org>
Cc: Rajesh Venkatasubramanian <vrajesh@umich.edu>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC] Generalized prio_tree, revisited
Date: Thu, 16 Dec 2004 06:15:17 -0300	[thread overview]
Message-ID: <20041216061517.O1229@almesberger.net> (raw)
In-Reply-To: <41C14F1B.8000401@kolivas.org>; from kernel@kolivas.org on Thu, Dec 16, 2004 at 08:02:19PM +1100

Con Kolivas wrote:
> While not being able to comment on the actual patch I think having a 1 
> or 0 for different types is not clear.

Yeah, it's not pretty. I also hope this division to be very
transitional, that's why I didn't bother to do anything nicer.

> Naming them different struct names would seem to me much more readable.

Struct names ? I'd rather not duplicate everything. Or did you mean
initialization function names, e.g. INIT_RAW_PRIO_TREE_ROOT ?
Or, for just the flag, maybe something like
#define PRIO_TREE_RAW		1
#define PRIO_TREE_NORMAL	0
?

- Werner

-- 
  _________________________________________________________________________
 / Werner Almesberger, Buenos Aires, Argentina     werner@almesberger.net /
/_http://www.almesberger.net/____________________________________________/

  reply	other threads:[~2004-12-16  9:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-16  8:31 [RFC] Generalized prio_tree, revisited Werner Almesberger
2004-12-16  9:02 ` Con Kolivas
2004-12-16  9:15   ` Werner Almesberger [this message]
2004-12-16  9:33     ` Con Kolivas
2004-12-16 13:23       ` Werner Almesberger
2004-12-16 11:12 ` Rajesh Venkatasubramanian
2004-12-16 13:57   ` Werner Almesberger
2004-12-16 15:04 ` Rajesh Venkatasubramanian
2004-12-16 19:38   ` Werner Almesberger
2004-12-16 20:01     ` Rajesh Venkatasubramanian
2004-12-17  4:44   ` Werner Almesberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041216061517.O1229@almesberger.net \
    --to=werner@almesberger.net \
    --cc=kernel@kolivas.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vrajesh@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.