From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: [discuss] Re: unregister_ioctl32_conversion and modules. ioctl32 revisited. Date: Thu, 16 Dec 2004 09:09:52 +0100 Message-ID: <20041216080952.GL32718@wotan.suse.de> References: <20041215065650.GM27225@wotan.suse.de> <20041215074635.GC11501@mellanox.co.il> <1103135460.18982.68.camel@krustophenia.net> <20041216050356.GH32718@wotan.suse.de> <20041216075301.GC11047@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20041216075301.GC11047@elte.hu> Sender: linux-kernel-owner@vger.kernel.org To: Ingo Molnar Cc: Andi Kleen , Lee Revell , Takashi Iwai , "Michael S. Tsirkin" , linux-kernel@vger.kernel.org, pavel@suse.cz, discuss@x86-64.org, gordon.jin@intel.com, alsa-devel , Andrew Morton , Greg KH List-Id: alsa-devel@alsa-project.org On Thu, Dec 16, 2004 at 08:53:01AM +0100, Ingo Molnar wrote: > > * Andi Kleen wrote: > > > > How does this all relate to Ingo's ->unlocked_ioctl stuff which is "an > > > official way to do BKL-less ioctls"? > > > > This is another "official" way which is more powerful. I suppose it > > will replace Ingo's patch. > > the ALSA changes are mine but i'm otherwise building ontop of the > following patch in -rc3-mm1: > > http://kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.10-rc3/2.6.10-rc3-mm1/broken-out/unlocked_ioctl.patch > > whichever approach gets adopted upstream, the various actors ought to > synchronize a bit more - this is the third approach so far in a very > short interval to get rid of the BKL in ioctls :-) I think Michael's patch is best (but I'm probably biased) because it addresses the independent problem of a race in unregister_ioctl32_conversion() too (and some other smaller issues in ioctl 32bit emulation) Andrew, could we replace unlocked_ioctl.patch with Michael's patch? Adapting depending code should be very easy, since only the name of the function vector has changed. -Andi