From: Greg KH <greg@kroah.com>
To: Chris Wright <chrisw@osdl.org>
Cc: Andrew Morton <akpm@osdl.org>,
"Adam J. Richter" <adam@yggdrasil.com>,
maneesh@in.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [Patch] Delete sysfs_dirent.s_count, saving ~100kB on my system
Date: Fri, 17 Dec 2004 15:27:52 -0800 [thread overview]
Message-ID: <20041217232752.GA24023@kroah.com> (raw)
In-Reply-To: <20041201155159.N14339@build.pdx.osdl.net>
On Wed, Dec 01, 2004 at 03:51:59PM -0800, Chris Wright wrote:
> * Andrew Morton (akpm@osdl.org) wrote:
> > That's all well and good, but sysfs_new_dirent() should be using a
> > standalone slab cache for allocating sysfs_dirent instances. That way, we
> > use 36 bytes for each one rather than 64.
>
> Reasonable, here's a patch (lightly tested). Without, size-64 looks
> like so:
>
> size-64 4064 4108 76 52 1 : tunables 32 16 8 : slabdata 79 79 0 : globalstat 4263 4079 79 0 0 0 84 0 : cpustat 15986 337 12286 3
>
> And with:
>
> size-64 1196 1196 76 52 1 : tunables 32 16 8 : slabdata 23 23 0 : globalstat 1297 1196 23 0 0 0 84 0 : cpustat 12418 108 11349 1
> sysfs_dir_cache 2862 2916 48 81 1 : tunables 32 16 8 : slabdata 36 36 0 : globalstat 2931 2874 36 0 0 0 113 0 : cpustat 2756 216 110 0
>
>
> Allocate sysfs_dirent structures from their own slab.
Nice, thanks for doing this.
Applied,
greg k-h
next prev parent reply other threads:[~2004-12-17 23:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-01 18:56 [Patch] Delete sysfs_dirent.s_count, saving ~100kB on my system Adam J. Richter
2004-12-01 21:07 ` Andrew Morton
2004-12-01 23:51 ` Chris Wright
2004-12-17 23:27 ` Greg KH [this message]
2004-12-30 13:34 ` Maneesh Soni
-- strict thread matches above, loose matches on Subject: below --
2004-12-02 2:59 Adam J. Richter
2004-11-23 4:08 Adam J. Richter
2004-11-22 19:17 Adam J. Richter
2004-11-22 22:53 ` Maneesh Soni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041217232752.GA24023@kroah.com \
--to=greg@kroah.com \
--cc=adam@yggdrasil.com \
--cc=akpm@osdl.org \
--cc=chrisw@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maneesh@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.