From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1Cg2xm-0000Se-66 for mharc-grub-devel@gnu.org; Sun, 19 Dec 2004 10:27:14 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1Cg2xa-0000R0-UV for grub-devel@gnu.org; Sun, 19 Dec 2004 10:27:03 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1Cg2xX-0000PJ-MM for grub-devel@gnu.org; Sun, 19 Dec 2004 10:26:59 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Cg2xX-0000Ob-Cr for grub-devel@gnu.org; Sun, 19 Dec 2004 10:26:59 -0500 Received: from [212.43.237.68] (helo=kotoba.storever.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Cg2mM-0006bS-K0 for grub-devel@gnu.org; Sun, 19 Dec 2004 10:15:26 -0500 Received: from ASSP-nospam (localhost [127.0.0.1]) by kotoba.storever.com (Postfix) with ESMTP id 0063DF6A0243 for ; Sun, 19 Dec 2004 16:15:26 +0100 (CET) Received: from 127.0.0.1 ([127.0.0.1] helo=localhost) by ASSP-nospam ; 19 Dec 04 15:15:25 -0000 From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Sun, 19 Dec 2004 16:15:26 +0100 User-Agent: KMail/1.7.1 References: <41BE9159.7010500@yahoo.fr> In-Reply-To: <41BE9159.7010500@yahoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200412191615.26966.okuji@enbug.org> Subject: Re: [PATCH] normal/cmdline.c : history contains empty lines X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Dec 2004 15:27:03 -0000 On Tuesday 14 December 2004 08:08, Vincent Pelletier wrote: > 2004-12-13 Vincent Pelletier > * grub_history_get : doesn't add empty lines, exits if called with > NULL argument > * grub_cmdline_get : command is added to history after user hit > "return", when pressing "down" arrow when on the most recent item in > history an empty line is shown I agree that empty lines should not be added into the history, but I don't think it is a good idea to show an empty line when you go down the history. Because I really like to have compatibility with BASH. I don't know how the current implementation behaves very well, but it should work in the same way as GRUB legacy. It should be like this: PROMPT HISTORY grub> [] foo[RET] grub> ["foo"] bar[RET] grub> ["foo", "bar"] [RET] grub> ["foo", "bar"] [C-p] grub> bar ["foo", "bar"] [C-n] grub> ["foo", "bar"] [C-p] grub> bar ["foo", "bar"] baz[RET] grub> ["foo", "bar", "barbaz"] Okuji