All of lore.kernel.org
 help / color / mirror / Atom feed
From: Willy Tarreau <willy@w.ods.org>
To: Andi Kleen <ak@suse.de>
Cc: discuss@x86-64.org, linux-kernel@vger.kernel.org,
	marcelo.tosatti@cyclades.com, vandrove@vc.cvut.cz
Subject: Re: [PATCH] [CAN-2004-1144] Fix int 0x80 hole in 2.4 x86-64 linux kernels
Date: Wed, 22 Dec 2004 19:20:48 +0100	[thread overview]
Message-ID: <20041222182048.GM17946@alpha.home.local> (raw)
In-Reply-To: <20041222175818.GA3363@wotan.suse.de>

Hi Andi,

On Wed, Dec 22, 2004 at 06:58:18PM +0100, Andi Kleen wrote:
(...)
>  	sti
> +	movl %eax,%eax	
>  	pushq %rax

Although I don't know about x86_64 assembly, I know x86 and I wonder
how this patch would do anything. I would personnaly have written something
more like :

+    movzl %eax,%rax

Once again, I may be wrong, but I really don't understand at all then.
Could you please either confirm or detail a bit more ?

thanks in advance,
Willy


  reply	other threads:[~2004-12-22 18:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-22 17:58 [PATCH] [CAN-2004-1144] Fix int 0x80 hole in 2.4 x86-64 linux kernels Andi Kleen
2004-12-22 18:20 ` Willy Tarreau [this message]
2004-12-22 18:23   ` Andi Kleen
2004-12-22 18:47     ` Willy Tarreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041222182048.GM17946@alpha.home.local \
    --to=willy@w.ods.org \
    --cc=ak@suse.de \
    --cc=discuss@x86-64.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.tosatti@cyclades.com \
    --cc=vandrove@vc.cvut.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.