From: Adrian Bunk <bunk@stusta.de>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] net/ipv4/: misc possible cleanups
Date: Tue, 28 Dec 2004 04:36:17 +0100 [thread overview]
Message-ID: <20041228033617.GI5345@stusta.de> (raw)
In-Reply-To: <20041227191535.5edce690.davem@davemloft.net>
On Mon, Dec 27, 2004 at 07:15:35PM -0800, David S. Miller wrote:
> On Wed, 15 Dec 2004 01:51:39 +0100
> Adrian Bunk <bunk@stusta.de> wrote:
>
> > - remove the following unneeded EXPORT_SYMBOL:
> > - tcp_timer.c: tcp_timer_bug_msg
>
> This one is wrong. It is needed for the ipv6 module
> via the call tcp_ipv6.c makes to tcp_done() which
> invokes tcp_clear_xmit_timer() which uses
> tcp_timer_bug_msg.
tcp_done doesn't call tcp_clear_xmit_timer, it calls
tcp_clear_xmit_timers (note the s) which is not an inline but an
EXPORT_SYMBOL'ed function in tcp_timer.c.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2004-12-28 3:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-15 0:51 [2.6 patch] net/ipv4/: misc possible cleanups Adrian Bunk
2004-12-28 3:15 ` David S. Miller
2004-12-28 3:36 ` Adrian Bunk [this message]
2004-12-28 4:04 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041228033617.GI5345@stusta.de \
--to=bunk@stusta.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.