From: "David S. Miller" <davem@davemloft.net>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: bunk@stusta.de, ralf@linux-mips.org, linux-hams@vger.kernel.org,
netdev@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] /net/ax25/: some cleanups
Date: Tue, 28 Dec 2004 10:05:07 -0800 [thread overview]
Message-ID: <20041228100507.7b374b5e.davem@davemloft.net> (raw)
In-Reply-To: <1104237408.20944.70.camel@localhost.localdomain>
On Tue, 28 Dec 2004 14:27:08 +0000
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> On Maw, 2004-12-28 at 02:51, David S. Miller wrote:
> > On Sun, 12 Dec 2004 22:13:39 +0100
> > Adrian Bunk <bunk@stusta.de> wrote:
> >
> > > The patch below contains the following cleanups:
> > > - make two needlessly global functions static
> > > - net/ax25/ax25_addr.c: remove the unused global function ax25digicmp
>
> Dave this function is only unused because a patch in 2.6.10 broke AX.25
> protocol support by removing the device and path checks. AX.25 is a link
> layer protocol it is supposed to check the devices and arguably the
> path.
Send a patch to netdev and CC: me to fix this as is standard
procedure for getting changes into the networking. :-)
next prev parent reply other threads:[~2004-12-28 18:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-12 21:13 [2.6 patch] /net/ax25/: some cleanups Adrian Bunk
2004-12-28 2:51 ` David S. Miller
2004-12-28 14:27 ` Alan Cox
2004-12-28 18:05 ` David S. Miller [this message]
2004-12-28 21:54 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041228100507.7b374b5e.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bunk@stusta.de \
--cc=linux-hams@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.