diff for duplicates of <20041228114258.35e9b5b7.khali@linux-fr.org> diff --git a/a/1.txt b/N1/1.txt index f706fcb..a841aa4 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -11,7 +11,7 @@ driver similar to the other hardware monitoring drivers. The adm1026 driver, OTOH, does use the id value in all debug messages, and it also only reconfigures the GPIO pins for the first client only -(id = 0). Although this is a real use of the id, it only matters if you +(id == 0). Although this is a real use of the id, it only matters if you use the module parameters for GPIO pins reconfiguration and actually have more than one ADM1026 chip (a quite rare chip if you remember). You don't necessarily know which ADM1026 will get id 0 anyway (if the chips @@ -19,7 +19,7 @@ are on different busses it depends on the order the bus drivers were loaded in), and I am not sure why one would want to reprogram only the first chip. Unless someone comes with such a specific hardware setup so that we can examine what is really needed, I think we can get rid of the -"id = 0" test and reconfigure "all" ADM1026 chips (which really is only +"id == 0" test and reconfigure "all" ADM1026 chips (which really is only one for the two known boards using an ADM1026). BTW, does anyone really use the GPIO pins reconfiguration parameters? diff --git a/a/content_digest b/N1/content_digest index 0875b17..600ef81 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,8 @@ "ref\020041227230402.272fafd0.khali@linux-fr.org\0" "ref\041D0942B.8020109@penguincomputing.com\0" - "From\0khali@linux-fr.org (Jean Delvare)\0" - "Subject\0[RFC] I2C: Remove the i2c_client id field\0" - "Date\0Thu, 19 May 2005 06:25:27 +0000\0" + "From\0Jean Delvare <khali@linux-fr.org>\0" + "Subject\0Re: [RFC] I2C: Remove the i2c_client id field\0" + "Date\0Tue, 28 Dec 2004 11:42:58 +0100\0" "To\0Philip Pokorny <ppokorny@penguincomputing.com>\0" "Cc\0LM Sensors <sensors@stimpy.netroedge.com>" LKML <linux-kernel@vger.kernel.org> @@ -22,7 +22,7 @@ "\n" "The adm1026 driver, OTOH, does use the id value in all debug messages,\n" "and it also only reconfigures the GPIO pins for the first client only\n" - "(id = 0). Although this is a real use of the id, it only matters if you\n" + "(id == 0). Although this is a real use of the id, it only matters if you\n" "use the module parameters for GPIO pins reconfiguration and actually\n" "have more than one ADM1026 chip (a quite rare chip if you remember). You\n" "don't necessarily know which ADM1026 will get id 0 anyway (if the chips\n" @@ -30,7 +30,7 @@ "loaded in), and I am not sure why one would want to reprogram only the\n" "first chip. Unless someone comes with such a specific hardware setup so\n" "that we can examine what is really needed, I think we can get rid of the\n" - "\"id = 0\" test and reconfigure \"all\" ADM1026 chips (which really is only\n" + "\"id == 0\" test and reconfigure \"all\" ADM1026 chips (which really is only\n" "one for the two known boards using an ADM1026).\n" "\n" "BTW, does anyone really use the GPIO pins reconfiguration parameters?\n" @@ -52,4 +52,4 @@ "Jean Delvare\n" http://khali.linux-fr.org/ -c6c08e49961036ac12fed533daef7758ff3b57ac527e10d3358d35851e764a54 +3a199bd108dbb0bbc4ee7bf4dc15c4bac08f2c400cf372b27bd0c6a6000ef4a5
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.