From: William Lee Irwin III <wli@holomorphy.com>
To: sparclinux@vger.kernel.org
Subject: Re: Sparc32 long long division patch
Date: Tue, 28 Dec 2004 22:18:28 +0000 [thread overview]
Message-ID: <20041228221828.GL771@holomorphy.com> (raw)
In-Reply-To: <41D1D929.8090004@wp.pl>
On Tue, Dec 28, 2004 at 11:07:37PM +0100, Krzysztof Helt wrote:
> I discovered a bug in multiply/division trap code for sun4m CPUs. This
> bug comes from not quite correct register declaration for inline
> assembly. According to GCC manual , it is not enough to declare a
> variable (register) as output only if it is an input variable as well. A
> special definitions "0" to "9" should match input variables and output
> variables. Due to this, GCC produced incorrect assembly code for muldiv
> trap function and division results were incorrect. The attached patch
> fixes this. I attached also a small program to test this bug.
Wow, I'm going to have to look at the generated assembly.
I'll send this along to marcelo and akpm later on today.
-- wli
next prev parent reply other threads:[~2004-12-28 22:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-28 22:07 Sparc32 long long division patch Krzysztof Helt
2004-12-28 22:18 ` William Lee Irwin III [this message]
2005-01-21 22:27 ` David S. Miller
2005-01-21 22:49 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041228221828.GL771@holomorphy.com \
--to=wli@holomorphy.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.