From: Wichert Akkerman <wichert@wiggy.net>
To: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
Cc: Jesper Juhl <juhl-lkml@dif.dk>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Steve French <sfrench@samba.org>,
Steve French <sfrench@us.ibm.com>,
samba-technical <samba-technical@lists.samba.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [patch 2/3] whitespace cleanups in fs/cifs/file.c
Date: Wed, 29 Dec 2004 10:51:30 +0100 [thread overview]
Message-ID: <20041229095129.GI24603@wiggy.net> (raw)
In-Reply-To: <20041229015716.GB29323@wohnheim.fh-wedel.de>
Previously Jörn Engel wrote:
> On Wed, 29 December 2004 00:52:32 +0100, Jesper Juhl wrote:
> > -static int cifs_relock_file(struct cifsFileInfo * cifsFile)
> > +static int
> > +cifs_relock_file(struct cifsFileInfo *cifsFile)
>
> Linus viciously prefers to keep return type and function name on a
> single line. I cannot quite follow his reasoning, but would leave
> that part out, unless explicitly requested by Steve.
If they are on a single line grep will find the return type as well
which is extremely convenient.
Wichert.
--
Wichert Akkerman <wichert@wiggy.net> It is simple to make things.
http://www.wiggy.net/ It is hard to make things simple.
next prev parent reply other threads:[~2004-12-29 9:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-26 23:24 [patch] copy_to_user check and whitespace cleanups in fs/cifs/file.c Jesper Juhl
2004-12-26 23:38 ` Alan Cox
2004-12-27 1:21 ` Jesper Juhl
2004-12-28 23:48 ` [patch 1/3] copy_to_user check " Jesper Juhl
2004-12-28 22:45 ` Alan Cox
2004-12-28 23:52 ` [patch 2/3] whitespace cleanups " Jesper Juhl
2004-12-29 1:57 ` Jörn Engel
2004-12-29 2:59 ` Jesper Juhl
2004-12-29 12:29 ` Jörn Engel
2004-12-29 18:48 ` Domen Puncer
2004-12-29 13:42 ` [patch 2/3] " Horst von Brand
2004-12-29 14:48 ` Jörn Engel
2004-12-29 16:31 ` Horst von Brand
2004-12-29 9:51 ` Wichert Akkerman [this message]
2004-12-29 12:10 ` Jörn Engel
2005-01-03 12:01 ` Martin Waitz
2004-12-28 23:55 ` [patch 3/3] get rid of two unnessesary assignments " Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041229095129.GI24603@wiggy.net \
--to=wichert@wiggy.net \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=joern@wohnheim.fh-wedel.de \
--cc=juhl-lkml@dif.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=sfrench@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.