From: corbet@lwn.net (Jonathan Corbet)
To: linux-os@analogic.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: remap_pfm_range() Linux-2.6.10
Date: Wed, 05 Jan 2005 08:38:43 -0700 [thread overview]
Message-ID: <20050105153843.13414.qmail@lwn.net> (raw)
In-Reply-To: Your message of "Wed, 05 Jan 2005 10:00:24 EST." <Pine.LNX.4.61.0501050951520.13645@chaos.analogic.com>
> Why wasn't PAGE_SHIFT put inside
> the new function? The base address cannot ever be used without
> PAGE_SHIFT. In previous versions, information hiding was properly
> used to hide the implementation details. Now, part of the implementation
> detail is exposed to interface code.
Hmm... seems to me that the new interface *removes* the page shift one
used to have to apply to the offset found in the VMA; looks like an
improvement to me.
Incidentally, the change allows the remapping of areas with physical
addresses beyond the 32-bit range, which, I believe, was why it was
done. Meanwhile, there's a nice compatibility function, so nobody's
driver broke. To me, there doesn't seem to be much to complain about.
jon
prev parent reply other threads:[~2005-01-05 15:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-05 15:00 remap_pfm_range() Linux-2.6.10 linux-os
2005-01-05 15:17 ` Andi Kleen
2005-01-05 15:38 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050105153843.13414.qmail@lwn.net \
--to=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-os@analogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.