Re: [PATCH] prevent sunrpc deadlock with debug on

[Olaf Kirch <okir@suse.de>]

Hi Trond,

On Wed, Dec 29, 2004 at 12:43:16AM +0100, Trond Myklebust wrote:
> I think I've found the real bug that Shirly was seeing. Can you ask her
> to test if this change fixes the actual problem?

I don't think that will be possible, but I'll ask her. The patch does
look correct though.

Still, if we ever run into a corrupted task struct, we will still
deadlock. How about this:

  show_tasks(void)
  {
        struct list_head *le;
        struct rpc_task *t;

-       spin_lock(&rpc_sched_lock);
+	if (!spin_trylock(&rpc_sched_lock))
+		return;
        if (list_empty(&all_tasks)) {
                spin_unlock(&rpc_sched_lock);


Olaf
-- 
Olaf Kirch     | Things that make Monday morning interesting, #2:
okir@suse.de   |        "We have 8,000 NFS mount points, why do we keep
---------------+ 	 running out of privileged ports?"


-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs