From: Simon Kirby <sim@netnation.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [2.6.10-bk7] Oops: ide_dma_timeout_retry
Date: Thu, 6 Jan 2005 14:18:02 -0800 [thread overview]
Message-ID: <20050106221801.GB1760@netnation.com> (raw)
In-Reply-To: <1105040975.17176.245.camel@localhost.localdomain>
On Thu, Jan 06, 2005 at 08:18:22PM +0000, Alan Cox wrote:
> Don't think it got discussed on l/k. Dunno if its in the 2.6.10bk code
> yet either
>
> rq->errors = 0;
>
> if (!rq->bio)
> goto out;
>
> rq->sector = rq->bio->bi_sector;
> rq->current_nr_sectors = bio_iovec(rq->bio)->bv_len >> 9;
> rq->hard_cur_sectors = rq->current_nr_sectors;
> rq->buffer = bio_data(rq->bio);
> out:
> return ret;
>
>
> Is how the code should look at the end of ide_dma_timeout_retry (plus
> your rq == NULL check I imagine)
The only difference with the code in 2.6.10 (ide-io.c is currently
unchanged in bk9) is rq->buffer is set to NULL instead of
bio_data(rq->bio)... I suppose this is the corruption fix?
Simon-
prev parent reply other threads:[~2005-01-06 22:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-05 23:33 [2.6.10-bk7] Oops: ide_dma_timeout_retry Simon Kirby
2005-01-06 16:30 ` Alan Cox
2005-01-06 19:23 ` Simon Kirby
2005-01-06 20:18 ` Alan Cox
2005-01-06 22:18 ` Simon Kirby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050106221801.GB1760@netnation.com \
--to=sim@netnation.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.