From: Adrian Bunk <bunk@stusta.de>
To: ext2-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org
Subject: [2.6 patch] fs/ext2/xattr.c: make ext2_xattr_list static
Date: Thu, 6 Jan 2005 23:47:34 +0100 [thread overview]
Message-ID: <20050106224734.GE28628@stusta.de> (raw)
The patch below makes the needlessly global function ext2_xattr_list
static.
diffstat output:
fs/ext2/xattr.c | 24 ++++++++++++------------
fs/ext2/xattr.h | 7 -------
2 files changed, 12 insertions(+), 19 deletions(-)
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-mm2-full/fs/ext2/xattr.h.old 2005-01-06 23:17:14.000000000 +0100
+++ linux-2.6.10-mm2-full/fs/ext2/xattr.h 2005-01-06 23:17:27.000000000 +0100
@@ -66,7 +66,6 @@
extern ssize_t ext2_listxattr(struct dentry *, char *, size_t);
extern int ext2_xattr_get(struct inode *, int, const char *, void *, size_t);
-extern int ext2_xattr_list(struct inode *, char *, size_t);
extern int ext2_xattr_set(struct inode *, int, const char *, const void *, size_t, int);
extern void ext2_xattr_delete_inode(struct inode *);
@@ -87,12 +86,6 @@
}
static inline int
-ext2_xattr_list(struct inode *inode, char *buffer, size_t size)
-{
- return -EOPNOTSUPP;
-}
-
-static inline int
ext2_xattr_set(struct inode *inode, int name_index, const char *name,
const void *value, size_t size, int flags)
{
--- linux-2.6.10-mm2-full/fs/ext2/xattr.c.old 2005-01-06 23:17:35.000000000 +0100
+++ linux-2.6.10-mm2-full/fs/ext2/xattr.c 2005-01-06 23:18:22.000000000 +0100
@@ -137,17 +137,6 @@
}
/*
- * Inode operation listxattr()
- *
- * dentry->d_inode->i_sem: don't care
- */
-ssize_t
-ext2_listxattr(struct dentry *dentry, char *buffer, size_t size)
-{
- return ext2_xattr_list(dentry->d_inode, buffer, size);
-}
-
-/*
* ext2_xattr_get()
*
* Copy an extended attribute into the buffer
@@ -260,7 +249,7 @@
* Returns a negative error number on failure, or the number of bytes
* used / required on success.
*/
-int
+static int
ext2_xattr_list(struct inode *inode, char *buffer, size_t buffer_size)
{
struct buffer_head *bh = NULL;
@@ -335,6 +324,17 @@
}
/*
+ * Inode operation listxattr()
+ *
+ * dentry->d_inode->i_sem: don't care
+ */
+ssize_t
+ext2_listxattr(struct dentry *dentry, char *buffer, size_t size)
+{
+ return ext2_xattr_list(dentry->d_inode, buffer, size);
+}
+
+/*
* If the EXT2_FEATURE_COMPAT_EXT_ATTR feature of this file system is
* not set, set it.
*/
reply other threads:[~2005-01-06 22:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050106224734.GE28628@stusta.de \
--to=bunk@stusta.de \
--cc=ext2-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.