From: Suparna Bhattacharya <suparna@in.ibm.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] fix double sync_page_range() in generic_file_aio_write()
Date: Fri, 7 Jan 2005 12:40:25 +0530 [thread overview]
Message-ID: <20050107071025.GA5498@in.ibm.com> (raw)
In-Reply-To: <41DAAA93.F96EAED7@tv-sign.ru>
Sorry I missed this one - Thanks for spotting it !
Regards
Suparna
On Tue, Jan 04, 2005 at 05:39:15PM +0300, Oleg Nesterov wrote:
> Hello.
>
> generic_file_aio_write():
> generic_file_aio_write_nolock():
> if (SYNC) sync_page_range_nolock();
> if (SYNC) sync_page_range();
>
> I think that generic_file_aio_write() should use
> __generic_file_aio_write_nolock() instead.
>
> Oleg.
>
> Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
>
> --- 2.6.10/mm/filemap.c~ 2004-11-15 17:12:21.000000000 +0300
> +++ 2.6.10/mm/filemap.c 2005-01-04 20:20:42.068803912 +0300
> @@ -2149,7 +2149,7 @@ ssize_t generic_file_aio_write(struct ki
> BUG_ON(iocb->ki_pos != pos);
>
> down(&inode->i_sem);
> - ret = generic_file_aio_write_nolock(iocb, &local_iov, 1,
> + ret = __generic_file_aio_write_nolock(iocb, &local_iov, 1,
> &iocb->ki_pos);
> up(&inode->i_sem);
--
Suparna Bhattacharya (suparna@in.ibm.com)
Linux Technology Center
IBM Software Lab, India
prev parent reply other threads:[~2005-01-07 7:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-04 14:39 [PATCH] fix double sync_page_range() in generic_file_aio_write() Oleg Nesterov
2005-01-07 7:10 ` Suparna Bhattacharya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050107071025.GA5498@in.ibm.com \
--to=suparna@in.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.