From: Christoph Hellwig <hch@infradead.org>
To: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
Cc: Roland Dreier <roland@topspin.com>, linux-kernel@vger.kernel.org
Subject: Re: Export get_sb_pseudo()?
Date: Sat, 8 Jan 2005 19:42:31 +0000 [thread overview]
Message-ID: <20050108194231.GA32285@infradead.org> (raw)
In-Reply-To: <20050108193101.GD26051@parcelfarce.linux.theplanet.co.uk>
On Sat, Jan 08, 2005 at 07:31:01PM +0000, Al Viro wrote:
> On Sat, Jan 08, 2005 at 10:40:10AM -0800, Roland Dreier wrote:
> > I'm planning on implementing some modular driver code and I think it
> > makes sense to have a non-mountable pseudofs. Especially with the
> > recent MVFS controversy, it seems prudent to find out whether this
> > usage would merit exporting get_sb_pseudo(), so I'll describe my
> > current plans below.
>
> No objections; it certainly falls under "general-purpose library
> helper". Moreover, in this case I _insist_ on use of normal
> export; it is a convenience helper that
> a) can be trivially reimplemented by anyone who cares; any
> number of filesystems is open-coding far more than that in their
> ->get_sb(), so there's nothing to protect here.
> b) can be trivially simulated by simple_fill_super() followed
> by a bit of tweaking the result.
> c) does not shove any pitchforks into the kernel guts - resulting
> superblock does not require any special treatment.
Agreed.
next prev parent reply other threads:[~2005-01-08 19:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <52k6qn229h.fsf@topspin.com>
2005-01-08 19:31 ` Export get_sb_pseudo()? Al Viro
2005-01-08 19:42 ` Christoph Hellwig [this message]
2005-01-08 20:33 ` [PATCH] Export get_sb_pseudo() Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050108194231.GA32285@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@topspin.com \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.