From: Jens Axboe <axboe@suse.de>
To: Hikaru1@verizon.net
Cc: linux-kernel@vger.kernel.org
Subject: Re: PROBLEM: ide-cd in 2.6.8-2.6.10 and 2.4.26-2.4.28 high cpu use with dma
Date: Sun, 9 Jan 2005 16:32:16 +0100 [thread overview]
Message-ID: <20050109153212.GA28417@suse.de> (raw)
In-Reply-To: <20050109123028.GA12753@roll>
On Sun, Jan 09 2005, Hikaru1@verizon.net wrote:
> A minor mistake. I forgot to state explicitly that the problem only appears
> with writing audio cds. Writing data cds does not cause problems.
The change isn't safe, it was made for a reason since some drives
timeout if the alignment/length isn't correct. It probably is a little
pessimistic right now, can you see if this just works for you?
===== drivers/ide/ide-cd.c 1.105 vs edited =====
--- 1.105/drivers/ide/ide-cd.c 2005-01-08 06:43:53 +01:00
+++ edited/drivers/ide/ide-cd.c 2005-01-09 16:31:53 +01:00
@@ -1915,7 +1915,7 @@
/*
* check if dma is safe
*/
- if ((rq->data_len & mask) || (addr & mask))
+ if ((rq->data_len & 3) || (addr & mask))
info->dma = 0;
}
--
Jens Axboe
next prev parent reply other threads:[~2005-01-09 15:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-09 10:52 PROBLEM: ide-cd in 2.6.8-2.6.10 and 2.4.26-2.4.28 high cpu use with dma Hikaru1
2005-01-09 10:54 ` Hikaru1
2005-01-09 12:30 ` Hikaru1
2005-01-09 15:32 ` Jens Axboe [this message]
2005-01-09 20:47 ` Marcel Sebek
2005-01-10 9:10 ` Hikaru1
2005-01-11 8:25 ` Jens Axboe
2005-01-09 23:01 ` Alan Cox
2005-01-10 8:45 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050109153212.GA28417@suse.de \
--to=axboe@suse.de \
--cc=Hikaru1@verizon.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.