From: Jens Axboe <axboe@suse.de>
To: Srihari Vijayaraghavan <sriharivijayaraghavan@yahoo.com.au>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PROBLEM] Badness in cfq_account_completion at drivers/block/cfq-iosched.c:916
Date: Tue, 11 Jan 2005 10:04:22 +0100 [thread overview]
Message-ID: <20050111090421.GG4551@suse.de> (raw)
In-Reply-To: <20050111052355.14035.qmail@web52604.mail.yahoo.com>
On Tue, Jan 11 2005, Srihari Vijayaraghavan wrote:
> I see zillion of these error messages in vanilla
> 2.6.10:
> Jan 11 16:10:13 linux kernel: [<c0220ee0>]
> scsi_end_request+0xa9/0xd6
[snip]
Does this fix it?
===== drivers/block/cfq-iosched.c 1.17 vs edited =====
--- 1.17/drivers/block/cfq-iosched.c 2004-12-24 09:12:58 +01:00
+++ edited/drivers/block/cfq-iosched.c 2005-01-11 10:03:17 +01:00
@@ -622,8 +622,10 @@
cfq_sort_rr_list(cfqq, 0);
}
- crq->accounted = 0;
- cfqq->cfqd->rq_in_driver--;
+ if (crq->accounted) {
+ crq->accounted = 0;
+ cfqq->cfqd->rq_in_driver--;
+ }
}
list_add(&rq->queuelist, &q->queue_head);
}
--
Jens Axboe
next prev parent reply other threads:[~2005-01-11 9:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-11 5:23 [PROBLEM] Badness in cfq_account_completion at drivers/block/cfq-iosched.c:916 Srihari Vijayaraghavan
2005-01-11 9:04 ` Jens Axboe [this message]
2005-01-12 1:36 ` Srihari Vijayaraghavan
2005-01-12 7:42 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050111090421.GG4551@suse.de \
--to=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sriharivijayaraghavan@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.