Re: [PATCH 0/6] 2.4.19-rc1 stack reduction patches

[Marcelo Tosatti <marcelo.tosatti@cyclades.com>]

On Tue, Jan 11, 2005 at 12:18:31PM +0100, Arjan van de Ven wrote:
> On Tue, 2005-01-11 at 05:49 -0200, Marcelo Tosatti wrote:
> > On Tue, Jan 11, 2005 at 08:39:03AM +0100, Arjan van de Ven wrote:
> > > On Mon, 2005-01-10 at 09:35 -0800, Badari Pulavarty wrote:
> > > > Hi Marcelo,
> > > > 
> > > > I re-worked all the applicable stack reduction patches for 2.4.19-rc1.
> > > 
> > > is it really worth doing this sort of thing for 2.4 still? It's a matter
> > > of risk versus gain... not sure this sort of thing is still worth it in
> > > the deep-maintenance 2.4 tree
> > 
> > Well it seems the s390 fellows are seeing stack overflows, which are serious
> > enough. Have you noticed that?
> 
> well.. is anyone using 2.4.2X mainline on s390, or is ibm making their
> s390 customers use vendor kernels instead? 
> (the people brave enough to not use those kernels might very well be
> using 2.6 by now)
> 
> Just trying to get a feeling for who if anyone will benefit inclusion of
> such patches, because if that is "just about nobody" then they might
> well not be worth the risk.

I understand your concern and appreciate it.

I dont expect anyone to be using v2.4 mainline on S390 (you need external 
patches to get it to work anyway) either :)

But the stack growth patches are also useful for other architectures I assume, 
its pretty hard to get them wrong (ie you're simple changing stack to 
kmalloc()'ed memory, the code is essentially the same). 

No?