From: domen@coderock.org
To: gadio@netvision.net.il
Cc: linux-kernel@vger.kernel.org, domen@coderock.org,
nacc@us.ibm.com, janitor@sternwelten.at
Subject: [patch 1/1] ide-tape: replace schedule_timeout() with msleep()
Date: Wed, 12 Jan 2005 00:16:18 +0100 [thread overview]
Message-ID: <20050111231619.558831F225@trashy.coderock.org> (raw)
I would appreciate any comments from the janitor@sternweltens list. This is one (of
many) cases where I made a decision about replacing
set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(some_time);
with
msleep(jiffies_to_msecs(some_time));
msleep() is not exactly the same as the previous code, but I only did
this replacement where I thought long delays were *desired*. If this is
not the case here, then just disregard this patch.
Thanks,
Nish
Description: Uses msleep() instead of schedule_timeout() to guarantee
the task delays at least the desired time amount.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
kj-domen/drivers/ide/ide-tape.c | 3 +--
1 files changed, 1 insertion(+), 2 deletions(-)
diff -puN drivers/ide/ide-tape.c~msleep-drivers_ide_ide-tape drivers/ide/ide-tape.c
--- kj/drivers/ide/ide-tape.c~msleep-drivers_ide_ide-tape 2005-01-10 17:59:47.000000000 +0100
+++ kj-domen/drivers/ide/ide-tape.c 2005-01-10 17:59:47.000000000 +0100
@@ -2854,8 +2854,7 @@ static int idetape_wait_ready(ide_drive_
} else if (!(tape->sense_key == 2 && tape->asc == 4 &&
(tape->ascq == 1 || tape->ascq == 8)))
return -EIO;
- current->state = TASK_INTERRUPTIBLE;
- schedule_timeout(HZ / 10);
+ msleep(100);
}
return -EIO;
}
_
next reply other threads:[~2005-01-11 23:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-11 23:16 domen [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-03-06 10:42 [patch 1/1] ide-tape: replace schedule_timeout() with msleep() domen
2005-06-20 21:52 domen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050111231619.558831F225@trashy.coderock.org \
--to=domen@coderock.org \
--cc=gadio@netvision.net.il \
--cc=janitor@sternwelten.at \
--cc=linux-kernel@vger.kernel.org \
--cc=nacc@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.