From: Pavel Machek <pavel@ucw.cz>
To: Domen Puncer <domen@coderock.org>
Cc: Andrew Morton <akpm@zip.com.au>,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: swsusp: more small fixes
Date: Wed, 12 Jan 2005 21:52:44 +0100 [thread overview]
Message-ID: <20050112205244.GH1408@elf.ucw.cz> (raw)
In-Reply-To: <20050112200611.GM4978@nd47.coderock.org>
Hi!
> > -struct highmem_page *highmem_copy = NULL;
> > +static struct highmem_page *highmem_copy = NULL;
>
> You could remove explicit initialization (so pointer would go into bss
> instead of data, IIRC).
>
> > - pr_debug("suspend: Allocating pagedir failed.\n");
> > + printk("suspend: Allocating pagedir failed.\n");
>
> Missing KERN_ constant.
> > - pr_debug("suspend: Allocating image pages failed.\n");
> > + printk("suspend: Allocating image pages failed.\n");
>
> Same here.
Fixed, but I'd prefer to have this applied and fix it with followup
patch.
Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
next prev parent reply other threads:[~2005-01-12 20:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-12 13:10 swsusp: more small fixes Pavel Machek
2005-01-12 20:06 ` Domen Puncer
2005-01-12 20:52 ` Pavel Machek [this message]
2005-01-12 22:10 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050112205244.GH1408@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@zip.com.au \
--cc=domen@coderock.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.