All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@engr.sgi.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Dave <dave.jiang@gmail.com>,
	torvalds@osdl.org, linux-kernel@vger.kernel.org,
	smaurer@teja.com, linux@arm.linux.org.uk, dsaxena@plexity.net,
	drew.moseley@intel.com, mporter@kernel.crashing.org
Subject: Re: [PATCH 1/5] Convert resource to u64 from unsigned long
Date: Thu, 13 Jan 2005 17:35:04 -0800	[thread overview]
Message-ID: <200501131735.04592.jbarnes@engr.sgi.com> (raw)
In-Reply-To: <20050113162309.2a125eb1.akpm@osdl.org>

On Thursday, January 13, 2005 4:23 pm, Andrew Morton wrote:
> +#if BITS_PER_LONG == 64
>  return (void __iomem *)pci_resource_start(pdev, PCI_ROM_RESOURCE);
> +#else
> + return (void __iomem *)(u32)pci_resource_start(pdev, PCI_ROM_RESOURCE);
> +#endif

I just noticed that the PCI rom code also appears to be mixing other types, 
e.g. it delcares start as loff_t and stuffs a pci_resource_start into it, 
then uses it as the first argument to ioremap.

Jesse

  parent reply	other threads:[~2005-01-14  1:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-13 23:26 [PATCH 1/5] Convert resource to u64 from unsigned long Dave
2005-01-14  0:23 ` Andrew Morton
2005-01-14  0:28   ` Dave
2005-01-14  0:43   ` Linus Torvalds
2005-01-14  0:48     ` Dave
2005-01-14  0:52   ` Al Viro
2005-01-14  0:52   ` Russell King
2005-01-14  1:35   ` Jesse Barnes [this message]
2005-01-14  3:49     ` Dave
2005-01-14  0:52 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200501131735.04592.jbarnes@engr.sgi.com \
    --to=jbarnes@engr.sgi.com \
    --cc=akpm@osdl.org \
    --cc=dave.jiang@gmail.com \
    --cc=drew.moseley@intel.com \
    --cc=dsaxena@plexity.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mporter@kernel.crashing.org \
    --cc=smaurer@teja.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.